Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix local volume issue on Windows #62012

Merged
merged 1 commit into from
Apr 3, 2018
Merged

fix local volume issue on Windows #62012

merged 1 commit into from
Apr 3, 2018

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Apr 2, 2018 •
edited
Loading

What this PR does / why we need it:
Actually local volume does not work on Windows up to now, with this PR, local volume would work on Windows. Here is a local volume example on Windows

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #62010

Special notes for your reviewer:
This PR would not MkdirAll(dir, 0750) on windows node, the MkdirAll process would happen on https://github.com/kubernetes/kubernetes/blob/master/pkg/util/mount/mount_windows.go#L59-L62

Release note:

fix local volume issue on Windows

/sig windows
/sig storage

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 2, 2018
feiskyer
feiskyer reviewed Apr 2, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2018
@andyzhangx
Copy link
Member Author

@msau42 PTAL, thanks. This is another PR to fix local volume issue on Windows.

@msau42
Copy link
Member

msau42 commented Apr 3, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 60983, 62012, 61892, 62051, 62067). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f167e16 into kubernetes:master Apr 3, 2018
@andyzhangx andyzhangx mentioned this pull request Apr 4, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 6, 2018
Merge pull request #62108 from andyzhangx/automated-cherry-pick-of-#6…
9e946a0 
…2012-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62012

Cherry pick of #62012 on release-1.10.

#62012: fix local volume issue on windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

local volume on Windows does not work
5 participants
@andyzhangx @msau42 @k8s-ci-robot @k8s-github-robot @feiskyer