Retry replication controller rolling updates on version mismatch. #6194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
/cc @jlowdermilk |
|
lgtm |
|
Good idea. Will do. |
|
Hi Prashanth Refactored as discussed. PTAL. Q |
|
just the one nit about the 4 time fields |
|
please also update your commit msg no reup, it seems to have unwanted gendocs stuff in it |
When kubectl does rolling updates of replication controllers, retry updates that fail due to version mismatches (caused by concurrent updates by other clients). These failed rolling updates were causing intermittent e2e test failures (e.g. issue 5821)
|
Thanks for the feedback Prashanth. All issues addressed. Ready for merge. |
|
LGTM, though I don't know if i missed a comment of yours across rebase or you have a use case for specifying 2 pairs of timeouts (one for the wait and one for the general retry) |
bprashanth
added
the
lgtm
|
LGTM, not sure if you're still waiting on e2e |
ghost
pushed a commit
that referenced
this pull request
Apr 3, 2015
Retry replication controller rolling updates on version mismatch.
ghost
merged commit
This was referenced May 15, 2015
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When kubectl does rolling updates of replication controllers, retry updates that
fail due to version mismatches (caused by concurrent updates by other clients).
These failed rolling updates were causing intermittent e2e test failures
(e.g. issue 5821)