Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFS Volume Plugin Info to Docs #6192

Merged
merged 1 commit into from
Mar 31, 2015
Merged

Add NFS Volume Plugin Info to Docs #6192

merged 1 commit into from
Mar 31, 2015

Conversation

wattsteve
Copy link
Contributor

Now that we have the NFS Volume Plugin committed, we need to edit the Volumes doc page to describe how to configure and use it. While the Plugin was committed with a pod file example,the example is minorly confusing in that it uses "nfs" as both the volume name and type. I've clarified this by renaming the name as "myshare" in the example, hence the inclusion of the example file in this PR.

Incidentally, the Volumes page is going to become an unnecessarily large if we include the pod example in-line with every plugin description. The NFS description links to the example file instead. I plan to follow this approach for the up-coming docs for Gluster File and Ceph Block.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@wattsteve
Copy link
Contributor Author

CLA signed as part of Red Hat

@vmarmol vmarmol self-assigned this Mar 30, 2015
@vmarmol
Copy link
Contributor

vmarmol commented Mar 30, 2015

LGTM, thanks @wattsteve! Can we squash commits and we'll merge

Update docs and example for NFS Plugin

Modified the wording around how many Volumes exist

Cleaned up the text around the NFS Pod description

Fixed Spelling mistake on read-only
@wattsteve
Copy link
Contributor Author

@vmarmol commits squashed

@vmarmol vmarmol added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2015
@vmarmol
Copy link
Contributor

vmarmol commented Mar 31, 2015

Thanks! We'll merge tomorrow when merge hours re-open.

vmarmol added a commit that referenced this pull request Mar 31, 2015
Add NFS Volume Plugin Info to Docs
@vmarmol vmarmol merged commit d11189f into kubernetes:master Mar 31, 2015
@wattsteve wattsteve deleted the patch-2 branch March 31, 2015 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants