[kubeadm] Bump kube-dns to 1.14.9 #61918
Conversation
k8s-ci-robot
added
release-note
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @timothysc |
MrHohn
force-pushed
the
kube-dns-1.14.9-kubeadm
branch
from
4d2bf76 to
ce2d2c7
Compare
k8s-ci-robot
removed
the
lgtm
|
Sorry missed a test file. Updated. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-kubernetes-node-e2e |
|
@MrHohn are you planning to cherry-pick this to 1.9 ? |
@xiangpengzhao Planning to cherrypick #61908, though not sure about the kubeadm one. |
|
ping @timothysc |
If we cherry-pick this PR, it mostly probably will be merged to the next patch version of 1.9 series (i.e., 1.9.7). When users upgrade kubernetes 1.9.7 to 1.10.0, kube-dns will be downgraded (i.e., from 1.14.9 to 1.14.8). Not sure if this will cause some issue, but users might be confused. |
|
/test pull-kubernetes-verify |
|
/retest |
|
@xiangpengzhao We would expect that users upgrade to the latest 1.10 patch release, not 1.10.0. If they follow this standard, then they will see no issues. |
|
@rramkumar1 but the coming 1.10.1 may be released later than the coming 1.9.7, right? If so, users may still upgrade from 1.9.7 to 1.10.0 |
|
@xiangpengzhao I would assume 1.10.1 and 1.9.7 are released pretty much at the same time. Even if they weren't, I don't think someone would upgrade to 1.9.7 and then immediately to 1.10.1 without leaving time for 1.10.2 to be released. Anyways, we are cherry picking this change back to 1.9 since the new kube-dns contains critical bug fixes so it needs to get in. |
|
@rramkumar1 agreed. I was also thinking of the case you mentioned. That's reasonable. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krousey, MrHohn, rramkumar1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@MrHohn: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue (batch tested with PRs 61918, 62180, 62198). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Bump kube-dns to 1.14.9 for kubeadm. Ref #61908.
cc @rramkumar1
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #NONE
Special notes for your reviewer:
Release note: