Make replication controller synchronizations independent. #618
+18
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Unsafe mock? |
| } | ||
| wait.Done() |
There was a problem hiding this comment.
You mean wait.Wait() here.
YMMV, but I prefer the name "wg" for waitgroups.
There was a problem hiding this comment.
Done and done.
|
Not unsafe mock, unsafe code ;) |
|
Fixed. (this is the biggest gotcha of go routing programming as far as I can tell. I'm way to used to better scope binding than this. If they can do it correctly in Scheme, why can't they do it correctly in go?) |
|
LGTM. This is gonna really pound apiserver periodically... may eventually want to spread out the syncing a little... Actually, nvm, when I get watch working reliably there'll be no need for this periodic sync. |
lavalamp
added a commit
that referenced
this pull request
Jul 25, 2014
Make replication controller synchronizations independent.
vishh
pushed a commit
to vishh/kubernetes
that referenced
this pull request
Apr 6, 2016
Add events endpoint to v2.0.
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Dec 8, 2016
…-aliyun-cloud-provider rebase aliyun cloud provider to 1.3.3
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Mar 3, 2017
…-aliyun-cloud-provider rebase aliyun cloud provider to 1.3.3
wking
pushed a commit
to wking/kubernetes
that referenced
this pull request
Jul 21, 2020
Address Doc Feedback
b3atlesfan
pushed a commit
to b3atlesfan/kubernetes
that referenced
this pull request
Feb 5, 2021
…ed_master Tolerate flannel running on master nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.