Auto-install gcloud and needed components, if necessary #6168
+30
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| echo "is not installed. (Fix with 'gcloud components update preview')" | ||
| } | ||
| local cmd | ||
| for cmd in gcloud; do |
There was a problem hiding this comment.
No reason to have a loop here any longer since the logic in the (single) iteration is gcloud specific. If you add another required command the whole loop body would become an if/else anyway.
| echo "Either the GCLOUD environment variable is wrong, or the 'preview' component" | ||
| echo "is not installed. (Fix with 'gcloud components update preview')" | ||
| } | ||
| local cmd |
There was a problem hiding this comment.
cmd is never set, and shouldn't be needed. replace occurrences of ${cmd} with gcloud.
|
Fixed. |
|
LGTM. |
roberthbailey
added a commit
that referenced
this pull request
Mar 31, 2015
Auto-install gcloud and needed components, if necessary
| local resp | ||
| read resp | ||
| if [[ "${KUBE_PROMPT_FOR_UPDATE" == "y" ]]; then |
There was a problem hiding this comment.
There's a missing } here. This is breaking jenkins.
There was a problem hiding this comment.
Ah, you caught it. :) I'll let @ixdy handle it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.