Adds e2e test for vpxd restart scenario in vSphere Cloud Provider #61614

venilnoronha · 2018-03-23T22:09:06Z

This PR adds a test to verify Volume access in a situation where VMware vCenter's vpxd service is down. The test mainly verifies Volume/file access before, during, and after restarting the vpxd service on the vCenter host.

See vmware-archive#373 for more details.

Reviewers note: This PR was internally reviewed at vmware-archive#468.

/cc @kubernetes/vmware

k8s-ci-robot · 2018-03-23T22:09:07Z

@venilnoronha: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abrarshivani · 2018-03-23T22:57:28Z

/release-note-none

abrarshivani · 2018-03-23T22:58:21Z

/ok-to-test

This commit adds a test to verify Volume access in a situation where VMware vCenter's vpxd service is down. The test mainly verifies Volume/file access before, during, and after restarting the vpxd service on the vCenter host.

abrarshivani · 2018-03-26T18:20:00Z

/test pull-kubernetes-integration

abrarshivani · 2018-04-04T00:31:30Z

/test pull-kubernetes-integration

venilnoronha · 2018-04-06T17:28:14Z

/assign divyenpatel

divyenpatel

/lgtm

venilnoronha · 2018-04-06T17:38:34Z

/assign @gnufied

abrarshivani · 2018-04-06T18:53:18Z

/test pull-kubernetes-e2e-gce

jeffvance · 2018-04-07T07:06:11Z

/test pull-kubernetes-e2e-gce

jeffvance · 2018-04-07T07:09:08Z

test/e2e/storage/vsphere/vsphere_volume_vpxd_restart.go

+	)
+
+	BeforeEach(func() {
+		framework.SkipUnlessProviderIs("vsphere")


does provider being vsphere imply ssh access?

Yes. I've added a comment in d101799.

jeffvance · 2018-04-07T07:10:23Z

test/e2e/storage/vsphere/vsphere_utils.go

+func invokeVCenterServiceControl(command, service, host string) error {
+	sshCmd := fmt.Sprintf("service-control --%s %s", command, service)
+	framework.Logf("Invoking command %v on vCenter host %v", sshCmd, host)
+	result, err := framework.SSH(sshCmd, host, framework.TestContext.Provider)


BeforeEach does not explicitly test for ssh access but this may be implied by verifying that the provider is vshpere/

That's correct.

jeffvance · 2018-04-07T07:22:46Z

test/e2e/storage/vsphere/vsphere_volume_vpxd_restart.go

+
+		nodes := framework.GetReadySchedulableNodesOrDie(client)
+		numNodes := len(nodes.Items)
+		if numNodes < 1 {


I see this in similar e2e tests:
Expect(numNodes).NotTo(BeZero(), "No available nodes for ...")

Addressed in d101799.

jeffvance · 2018-04-07T07:30:18Z

I don't understand the details of vsphere, but from an e2e perspective this lgtm

venilnoronha · 2018-04-09T18:28:20Z

/assign @abrarshivani

abrarshivani · 2018-04-09T18:30:38Z

/lgtm

abrarshivani · 2018-04-09T20:24:14Z

/test pull-kubernetes-bazel-build

jeffvance · 2018-04-09T20:50:42Z

/lgtm

gnufied · 2018-04-09T22:43:40Z

/approve

k8s-ci-robot · 2018-04-09T22:43:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrarshivani, divyenpatel, gnufied, jeffvance, venilnoronha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/e2e/storage/OWNERS~~ [gnufied]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fejta-bot · 2018-04-10T01:57:52Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot · 2018-04-10T04:24:51Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot · 2018-04-10T07:54:52Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot · 2018-04-10T12:27:52Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

k8s-github-robot · 2018-04-10T15:00:57Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-ci-robot · 2018-04-10T15:04:26Z

@venilnoronha: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-bazel-build	`d101799`	link	`/test pull-kubernetes-bazel-build`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-github-robot · 2018-04-10T15:56:17Z

Automatic merge from submit-queue (batch tested with PRs 60197, 61614, 62074, 62071, 62301). If you want to cherry-pick this change to another branch, please follow the instructions here.

k8s-ci-robot requested review from copejon and davidz627 March 23, 2018 22:09

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 23, 2018

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 23, 2018

Adds e2e test for the VMware vpxd restart scenario

e90246d

This commit adds a test to verify Volume access in a situation where VMware vCenter's vpxd service is down. The test mainly verifies Volume/file access before, during, and after restarting the vpxd service on the vCenter host.

venilnoronha force-pushed the vpxd-restart-test branch from bdce5ea to e90246d Compare March 23, 2018 23:49

k8s-ci-robot assigned divyenpatel Apr 6, 2018

divyenpatel approved these changes Apr 6, 2018

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2018

k8s-ci-robot assigned gnufied Apr 6, 2018

jeffvance reviewed Apr 7, 2018

View reviewed changes

Addresses review comments

d101799

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2018

k8s-ci-robot assigned abrarshivani Apr 9, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2018

k8s-ci-robot assigned jeffvance Apr 9, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2018

k8s-github-robot merged commit cc82636 into kubernetes:master Apr 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds e2e test for vpxd restart scenario in vSphere Cloud Provider #61614

Adds e2e test for vpxd restart scenario in vSphere Cloud Provider #61614

venilnoronha commented Mar 23, 2018

k8s-ci-robot commented Mar 23, 2018

abrarshivani commented Mar 23, 2018

abrarshivani commented Mar 23, 2018

abrarshivani commented Mar 26, 2018

abrarshivani commented Apr 4, 2018

venilnoronha commented Apr 6, 2018

divyenpatel left a comment

venilnoronha commented Apr 6, 2018

abrarshivani commented Apr 6, 2018

jeffvance commented Apr 7, 2018

jeffvance Apr 7, 2018

venilnoronha Apr 9, 2018

jeffvance Apr 7, 2018

venilnoronha Apr 9, 2018

jeffvance Apr 7, 2018 •

edited

Loading

venilnoronha Apr 9, 2018

jeffvance commented Apr 7, 2018

venilnoronha commented Apr 9, 2018

abrarshivani commented Apr 9, 2018

abrarshivani commented Apr 9, 2018

jeffvance commented Apr 9, 2018

gnufied commented Apr 9, 2018

k8s-ci-robot commented Apr 9, 2018

fejta-bot commented Apr 10, 2018

fejta-bot commented Apr 10, 2018

fejta-bot commented Apr 10, 2018

fejta-bot commented Apr 10, 2018

k8s-github-robot commented Apr 10, 2018

k8s-ci-robot commented Apr 10, 2018 •

edited

Loading

k8s-github-robot commented Apr 10, 2018

Adds e2e test for vpxd restart scenario in vSphere Cloud Provider #61614

Adds e2e test for vpxd restart scenario in vSphere Cloud Provider #61614

Conversation

venilnoronha commented Mar 23, 2018

k8s-ci-robot commented Mar 23, 2018

abrarshivani commented Mar 23, 2018

abrarshivani commented Mar 23, 2018

abrarshivani commented Mar 26, 2018

abrarshivani commented Apr 4, 2018

venilnoronha commented Apr 6, 2018

divyenpatel left a comment

Choose a reason for hiding this comment

venilnoronha commented Apr 6, 2018

abrarshivani commented Apr 6, 2018

jeffvance commented Apr 7, 2018

jeffvance Apr 7, 2018

Choose a reason for hiding this comment

venilnoronha Apr 9, 2018

Choose a reason for hiding this comment

jeffvance Apr 7, 2018

Choose a reason for hiding this comment

venilnoronha Apr 9, 2018

Choose a reason for hiding this comment

jeffvance Apr 7, 2018 • edited Loading

Choose a reason for hiding this comment

venilnoronha Apr 9, 2018

Choose a reason for hiding this comment

jeffvance commented Apr 7, 2018

venilnoronha commented Apr 9, 2018

abrarshivani commented Apr 9, 2018

abrarshivani commented Apr 9, 2018

jeffvance commented Apr 9, 2018

gnufied commented Apr 9, 2018

k8s-ci-robot commented Apr 9, 2018

fejta-bot commented Apr 10, 2018

fejta-bot commented Apr 10, 2018

fejta-bot commented Apr 10, 2018

fejta-bot commented Apr 10, 2018

k8s-github-robot commented Apr 10, 2018

k8s-ci-robot commented Apr 10, 2018 • edited Loading

k8s-github-robot commented Apr 10, 2018

jeffvance Apr 7, 2018 •

edited

Loading

k8s-ci-robot commented Apr 10, 2018 •

edited

Loading