Fix "brctl: invalid command" message appearing in startup logs #6148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Forcibly install bridge-utils (options borrowed from Salt logs). | ||
| until apt-get -q -y -o DPkg::Options::=--force-confold -o DPkg::Options::=--force-confdef install bridge-utils; do | ||
| echo "== install of bridge-utils failed, retrying ==" | ||
| echo sleep 5 |
There was a problem hiding this comment.
did you really mean "echo sleep 5" or just "sleep 5" ?
There was a problem hiding this comment.
Hah. Good catch. Probably not, no. Will fix in front of a real computer.
On Mar 29, 2015 2:26 PM, "David Oppenheimer" notifications@github.com
wrote:
In cluster/gce/configure-vm.sh
#6148 (comment)
:@@ -83,10 +83,18 @@ for k,v in yaml.load(sys.stdin).iteritems():
}function remove-docker-artifacts() {
- echo "== Deleting docker0 =="
Forcibly install bridge-utils (options borrowed from Salt logs).
- until apt-get -q -y -o DPkg::Options::=--force-confold -o DPkg::Options::=--force-confdef install bridge-utils; do
- echo "== install of bridge-utils failed, retrying =="
- echo sleep 5
did you really mean "echo sleep 5" or just "sleep 5" ?
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/6148/files#r27359276
.
We were actually failing to call brctl in configure-vm.sh. I finally tracked it down to the attempt to delete the docker0 bridge. This particular package was getting installed later by Salt anyways, so all this PR is doing is moving the package install up from Salt to bash. Also adds some minor logging.
zmerlynn
force-pushed
the
brctl_complaint
branch
from
1852e9f to
b3636bb
Compare
|
Fixed, PTAL. |
|
LGTM |
davidopp
added
the
lgtm
vmarmol
added a commit
that referenced
this pull request
Mar 30, 2015
Fix "brctl: invalid command" message appearing in startup logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were actually failing to call brctl in configure-vm.sh. I finally
tracked it down to the attempt to delete the docker0 bridge. This
particular package was getting installed later by Salt anyways, so
all this PR is doing is moving the package install up from Salt to
bash.
Also adds some minor logging.