getting 7bc7f47 fully right. #6135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioMeireles
referenced
this pull request
Mar 28, 2015
…nfigs. Signed-off-by: António Meireles <antonio.meireles@reformi.st>
|
And so we're back to the amazing |
|
the alternative is to have an etcd cluster locally as i do in my tree (and it works), or play with etcd proxy so that it etcd looks present in all nodes - but either way that means jumping into etcd v2 (as i did) which isn't yet 'native' to CoreOS... (which is why here i m refraining from doing it :-) ) |
given that etcd is disabled in the nodes we need to wait for master's etcd to be available so that flanneld gets properly wired. Signed-off-by: António Meireles <antonio.meireles@reformi.st>
|
LGTM. |
brendandburns
added a commit
that referenced
this pull request
Mar 30, 2015
getting 7bc7f47 fully right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given that etcd is disabled in the nodes we need to wait for master's etcd to be
available so that flanneld gets properly wired.
[@brendanburns sorry for mixup.]