Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated gcloud compute networks --mode switches. #61203

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Fix deprecated gcloud compute networks --mode switches. #61203

merged 1 commit into from
Mar 16, 2018

Conversation

rmmh
Copy link
Contributor

@rmmh rmmh commented Mar 14, 2018 •
edited
Loading

"create --mode" becomes "create --subnet-mode", and switch-mode has been
folded into "update".

Create --mode was deprecated in October and will be removed in the next
gcloud release. It is already failing in staging tests.
What this PR does / why we need it:

Which issue(s) this PR fixes Fixes #54238

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 14, 2018
@rmmh rmmh added this to the v1.10 milestone Mar 14, 2018
ixdy
ixdy reviewed Mar 14, 2018
View reviewed changes
cluster/gce/util.sh Outdated
@@ -1675,7 +1675,7 @@ function create-network() {

function expand-default-subnetwork() {
gcloud compute networks switch-mode "${NETWORK}" \
--mode custom \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is still --subnet-mode.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but also

SYNOPSIS
    gcloud compute networks switch-mode NAME --mode=MODE [GCLOUD_WIDE_FLAG ...]

DESCRIPTION
    (DEPRECATED) switch-mode is deprecated. Please use
    --switch-to-custom-subnet-mode with gcloud compute networks update instead.

    gcloud compute networks switch-mode is used to change the mode of a
    network. Currently, only changing from auto to custom mode is supported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Fix deprecated gcloud compute networks --mode switches.
68f5d44 
"create --mode" becomes "create --subnet-mode", and switch-mode has been
folded into "update".

Create --mode was deprecated in October and will be removed in the next
gcloud release. It is already failing in staging tests.
@rmmh rmmh changed the title Use gcloud compute networks --subnet-mode instead of --mode. Fix deprecated gcloud compute networks --mode switches. Mar 14, 2018
@rmmh
Copy link
Contributor Author

rmmh commented Mar 14, 2018

/retest

@krzyzacy
Copy link
Member

gke test need a kubetest bump, sending out

@cblecker
Copy link
Member

/sig testing
/priority critical-urgent
/kind bug

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/bug Categorizes issue or PR as related to a bug. labels Mar 14, 2018
@krzyzacy
Copy link
Member

/status approved-for-milestone

@cblecker
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2018
@rmmh
Copy link
Contributor Author

rmmh commented Mar 14, 2018

/retest

@krzyzacy
Copy link
Member

/retest
gce looks like flaky

@ixdy
Copy link
Member

ixdy commented Mar 14, 2018

hmm:

failed to create Stackdriver Logging sink: googleapi: Error 400: There is a maximum of 90 sinks allowed, failedPrecondition

@cblecker
Copy link
Member

/assign @gmarek
for approval

@liggitt
Copy link
Member

liggitt commented Mar 15, 2018

are these changes needed in release branches as well?

@krzyzacy
Copy link
Member

@liggitt yep (this will not be blocking for gce until this gcloud staging version come to prod, and we bump gcloud in e2e image)

@krzyzacy
Copy link
Member

/assign @mikedanese @roberthbailey
can someone approve?

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@cblecker @gmarek @krzyzacy @mikedanese @rmmh @roberthbailey

Pull Request Labels
  • sig/testing: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@krzyzacy krzyzacy mentioned this pull request Mar 15, 2018
Closed
@roberthbailey
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, rmmh, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2018
@roberthbailey
Copy link
Contributor

Do we need to backport this to any old release branches to keep the upgrade tests working?

@tpepper
Copy link
Member

tpepper commented Mar 15, 2018

@roberthbailey see #54238 for the over arching issue status. Indication there is yes on backports.

@krzyzacy
Copy link
Member

yep, we don't bind kubernetes with specific gcloud versions, each active branch should be able to run with latest gcloud.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 61203, 61071). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5f78093 into kubernetes:master Mar 16, 2018
@jberkus jberkus mentioned this pull request Mar 26, 2018
Merged
This was referenced Apr 11, 2018
Closed
Merged
Merged
Closed
@wojtek-t wojtek-t mentioned this pull request Apr 11, 2018
Merged
@shyamjvs shyamjvs mentioned this pull request Apr 11, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 11, 2018
Merge pull request #62381 from shyamjvs/automated-cherry-pick-of-#612…
8419267 
…03-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #61203: Fix deprecated gcloud compute networks --mode switches.

Cherry pick of #61203 on release-1.9.

#61203: Fix deprecated gcloud compute networks --mode switches.

```release-note
NONE
```
k8s-github-robot pushed a commit that referenced this pull request Apr 11, 2018
Merge pull request #62380 from wojtek-t/automated-cherry-pick-of-#612…
c57c66e 
…03-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #61203 upstream release 1.8

Cherry pick of #61203 on release-1.8.
#61203 : Fix deprecated gcloud compute networks --mode switches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixdy ixdy ixdy left review comments

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@vishh vishh Awaiting requested review from vishh

Assignees

@krzyzacy krzyzacy

@cblecker cblecker

@gmarek gmarek

@mikedanese mikedanese

@roberthbailey roberthbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

cluster/gce uses deprecated gcloud parameter "mode"