Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates kubeadm default to use 1.10 #61127

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Updates kubeadm default to use 1.10 #61127

merged 1 commit into from
Mar 19, 2018

Conversation

timothysc
Copy link
Member

What this PR does / why we need it:
In line with https://github.com/kubernetes/kubeadm/blob/master/docs/release-cycle.md, the default branch for kubeadm to deploy should be bumped right before the rc.1.
This can even be manually merged by the someone from the release team.

Which issue(s) this PR fixes :
Fixes #60608

Special notes for your reviewer:

Release note:

Updates default deployment for kubeadm to 1.10

/cc @kubernetes/sig-cluster-lifecycle-pr-reviews @kubernetes/sig-release-members @dims @jberkus @jdumars

@timothysc timothysc added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. area/kubeadm do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 13, 2018
@timothysc timothysc added this to the v1.10 milestone Mar 13, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 13, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2018
@timothysc
Copy link
Member Author

Someone from the release team will have to switch the labels when rc.1 is ready to be cut.

@timothysc timothysc added status/approved-for-milestone and removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 13, 2018
@jdumars
Copy link
Member

jdumars commented Mar 13, 2018

Can we get the LGTM so we're not scrambling at the last minute when it's time to merge?

@timothysc timothysc mentioned this pull request Mar 13, 2018
Closed
@kad
Copy link
Member

kad commented Mar 13, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2018
jamiehannaford
jamiehannaford approved these changes Mar 14, 2018
View reviewed changes
Copy link
Contributor

@jamiehannaford jamiehannaford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spiffxp spiffxp mentioned this pull request Mar 15, 2018
Closed
luxas
luxas approved these changes Mar 18, 2018
View reviewed changes
Copy link
Member

@luxas luxas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jamiehannaford, kad, luxas, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@calebamiles @jamiehannaford @jdumars @kad @luxas @timothysc

Pull Request Labels
  • sig/cluster-lifecycle: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/cleanup: Adding tests, refactoring, fixing old bugs.
Help

@jdumars
Copy link
Member

jdumars commented Mar 19, 2018

/status in-progress

@liggitt
Copy link
Member

liggitt commented Mar 19, 2018

/retest

@jdumars jdumars removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-blocker labels Mar 19, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 7bcfbcd into kubernetes:master Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas approved these changes

@jamiehannaford jamiehannaford jamiehannaford approved these changes

@mattmoyer mattmoyer Awaiting requested review from mattmoyer

Assignees

@kad kad

@calebamiles calebamiles

@jdumars jdumars

@jamiehannaford jamiehannaford

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

kubeadm v1.10 release tracking issue
9 participants
@timothysc @jdumars @kad @k8s-ci-robot @k8s-github-robot @liggitt @jamiehannaford @luxas @calebamiles