Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase apiserver mem-threshold in density test #61118

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Increase apiserver mem-threshold in density test #61118

merged 1 commit into from
Mar 14, 2018

Conversation

shyamjvs
Copy link
Member

@shyamjvs shyamjvs commented Mar 13, 2018 •
edited
Loading

Ref: #60500 (comment) (fixes part of that issue)

/sig scalability
/kind bug
/priority important-soon
/cc @wojtek-t
/cc @crassirostris (for the release-note)

Audit logging with buffering enabled can increase apiserver memory usage (e.g. up to 200MB in 100-node cluster). The increase is bounded by the buffer size (configurable). Ref: issue #60500

@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t March 13, 2018 17:02
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 13, 2018
@shyamjvs shyamjvs added this to the v1.10 milestone Mar 13, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2018
@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 13, 2018
@shyamjvs shyamjvs mentioned this pull request Mar 13, 2018
Closed
@shyamjvs shyamjvs requested a review from gmarek March 14, 2018 13:46
@gmarek
Copy link
Contributor

gmarek commented Mar 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmarek, shyamjvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@gmarek @shyamjvs

Pull Request Labels
  • sig/scalability: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@shyamjvs
Copy link
Member Author

@crassirostris Could you PTAL at the release-note?

@crassirostris
Copy link

@shyamjvs I'd shorten it:

Audit logging with buffering enabled can increase apiserver memory usage (e.g. up to 200MB in 100-node cluster). Ref: issue #60500

@shyamjvs
Copy link
Member Author

Thanks - changed it. Also added The increase is bounded by the buffer size (configurable). to make it clear it's not an arbitrary/unpredicatable increase.

@crassirostris
Copy link

crassirostris commented Mar 14, 2018 •
edited
Loading

SGTM

Thanks!

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 61118, 60579). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 05ec0a7 into kubernetes:master Mar 14, 2018
@shyamjvs shyamjvs deleted the bump-apiserver-mem-threshold branch March 14, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@gmarek gmarek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
5 participants
@shyamjvs @gmarek @k8s-ci-robot @k8s-github-robot @crassirostris