Remove pods from the assumed pod list when they are deleted #6110
+156
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bprashanth @davidopp @abhgupta Partial resolution for #6023; |
|
random nitty comments |
|
Updated. PTAL |
|
OK, and test added (yes, the test fails the old behavior). PTAL. Would like to get this in ASAP. |
|
LGTM |
|
Is this PR now ready for a merge? |
|
Not sure if @lavalamp is waiting on/finished e2e, otherwise it should be |
bprashanth
added
the
lgtm
|
This should be good to go! |
vmarmol
added a commit
that referenced
this pull request
Mar 30, 2015
Remove pods from the assumed pod list when they are deleted
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduler factory needs a test that constructs a scheduler and tests it. Really this change should be tested there. Thinking about that...