Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to etcd 3.1.12 to pick up critical fix #60998

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Bump to etcd 3.1.12 to pick up critical fix #60998

merged 1 commit into from
Mar 13, 2018
+83 −73

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Mar 9, 2018 •
edited
Loading

etcd 3.1.12 (as well as 3.2.17 and 3.3.2) was released yesterday to fix a bug critical to kubernetes:

Fix mvcc "unsynced" watcher restore operation.

  • "unsynced" watcher is watcher that needs to be in sync with events that have happened.
  • That is, "unsynced" watcher is the slow watcher that was requested on old revision.
  • "unsynced" watcher restore operation was not correctly populating its underlying watcher group.
  • Which possibly causes missing events from "unsynced" watchers.

This will be backported to 1.9 as well.

Release note:

Upgrade the default etcd server version to 3.1.12 to pick up critical etcd "mvcc "unsynced" watcher restore operation" fix.

cc @gyuho @wojtek-t @shyamjvs @timothysc @jdumars

@jpbetz jpbetz added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/etcd sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/gcp labels Mar 9, 2018
@jpbetz jpbetz added this to the v1.10 milestone Mar 9, 2018
@jpbetz jpbetz self-assigned this Mar 9, 2018
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2018
jpbetz
jpbetz commented Mar 9, 2018
View reviewed changes
cluster/images/etcd/Makefile Outdated
REGISTRY?=k8s.gcr.io
# Images should be pushed to staging-k8s.gcr.io, which is aliased to gcr.io/google-containers.
# But currently that does not work, so we must instead push to gcr.io/google-containers directly.
PUSH_REGISTRY?=gcr.io/google-containers
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing directly to staging-k8s.gcr.io did not work for me although from #57824 it looks like it is suppose to. Anyone know why?

cc @thockin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you tell what the error is? Maybe it's related to the one I was seeing yesterday - #60891 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I either get this (for layer pushes):

The push refers to a repository [staging-k8s.gcr.io/etcd]
21172253818c: Retrying in 5 seconds 
6689586d0bd6: Retrying in 4 seconds

Or, this (if layers already exist, but something needs to be tagged):

denied: Permission 'storage.objects.create' denied for bucket 'artifacts.google-containers.appspot.com'

Happens using both docker <cmd> and gcloud docker -- <cmd> works works if i instead do the same against gcr.io/google-containers. Permissions issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try gcloud auth login and authenticate yourself as k8s.production.user@?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, make sure you have gcloud 185.0.0 or newer and run gcloud beta auth configure-docker - this should allow docker push to work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixed the problem. Thanks @ixdy! I'll update this PR.

@jpbetz jpbetz added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 9, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 9, 2018
cblecker
cblecker reviewed Mar 9, 2018
View reviewed changes
CHANGELOG-1.9.md Outdated
@@ -304,7 +304,7 @@ filename | sha256 hash
* Fixes a possible deadlock preventing quota from being recalculated ([#58107](https://github.com/kubernetes/kubernetes/pull/58107), [@ironcladlou](https://github.com/ironcladlou))
* Fixes a bug in Heapster deployment for google sink. ([#57902](https://github.com/kubernetes/kubernetes/pull/57902), [@kawych](https://github.com/kawych))
* GCE: Allows existing internal load balancers to continue using an outdated subnetwork ([#57861](https://github.com/kubernetes/kubernetes/pull/57861), [@nicksardo](https://github.com/nicksardo))
* Update etcd version to 3.1.11 ([#57811](https://github.com/kubernetes/kubernetes/pull/57811), [@xiangpengzhao](https://github.com/xiangpengzhao))
* Update etcd version to 3.1.12 ([#57811](https://github.com/kubernetes/kubernetes/pull/57811), [@xiangpengzhao](https://github.com/xiangpengzhao))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be a mistake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Reverting.

@jpbetz jpbetz force-pushed the etcd-3.1.12 branch 2 times, most recently from 7a8afcd to 4b794b5 Compare March 9, 2018 22:18
@ixdy
Copy link
Member

ixdy commented Mar 9, 2018

/approve
/retest

@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 10, 2018

/retest

@dims
Copy link
Member

dims commented Mar 10, 2018

/test pull-kubernetes-e2e-gke

@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 11, 2018

pull-kubernetes-e2e-gke failures are failing across the board: https://k8s-gubernator.appspot.com/builds/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-e2e-gke

@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 11, 2018

/retest

1 similar comment
@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 11, 2018

/retest

@cblecker
Copy link
Member

@jpbetz This isn’t a flake: #61009

@cblecker
Copy link
Member

/retest

cblecker
cblecker approved these changes Mar 12, 2018
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@cblecker
Copy link
Member

/assign @mikedanese @sttts
for approval

timothysc
timothysc reviewed Mar 13, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@jpbetz @mikedanese @sttts @timothysc

Pull Request Labels
  • sig/api-machinery sig/gcp: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@sttts
Copy link
Contributor

sttts commented Mar 13, 2018

/approve

@wojtek-t
Copy link
Member

/approve no-issue

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ixdy, jpbetz, sttts, timothysc, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit b651ed5 into kubernetes:master Mar 13, 2018
@shyamjvs shyamjvs mentioned this pull request Mar 14, 2018
Closed
3 tasks
@tpepper tpepper mentioned this pull request Mar 26, 2018
Merged
@superseb superseb mentioned this pull request Mar 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc left review comments

@cblecker cblecker cblecker approved these changes

@enisoc enisoc Awaiting requested review from enisoc

@gmarek gmarek Awaiting requested review from gmarek

@ixdy ixdy Awaiting requested review from ixdy

@jamiehannaford jamiehannaford Awaiting requested review from jamiehannaford

@lavalamp lavalamp Awaiting requested review from lavalamp

@saad-ali saad-ali Awaiting requested review from saad-ali

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

@sttts sttts Awaiting requested review from sttts

@thockin thockin Awaiting requested review from thockin

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@timothysc timothysc

@jpbetz jpbetz

@sttts sttts

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/etcd cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.