Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set node external IP for azure node when disabling UseInstanceMetadata #60959

Merged
merged 2 commits into from
Mar 9, 2018
Merged

Set node external IP for azure node when disabling UseInstanceMetadata #60959

merged 2 commits into from
Mar 9, 2018

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Mar 9, 2018 •
edited
Loading

What this PR does / why we need it:

This PR sets node external IP for azure node disabling UseInstanceMetadata.

It also adds a check of whether it is running locally when UseInstanceMetadata.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #60958

Special notes for your reviewer:

Release note:

Set node external IP for azure node when disabling UseInstanceMetadata

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2018
@feiskyer
Copy link
Member Author

feiskyer commented Mar 9, 2018

/sig azure

@feiskyer
Copy link
Member Author

feiskyer commented Mar 9, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 9, 2018
@andyzhangx
Copy link
Member

@feiskyer if it's a bug, is there a bug description?

@feiskyer
Copy link
Member Author

feiskyer commented Mar 9, 2018

@andyzhangx Yep, forgot to include it. It fixes #60958.

@khenidak
Copy link
Contributor

khenidak commented Mar 9, 2018

While the code is good to go (specially in case of current node). I am not sure if we should assign public/external IPs to nodes. Do we assign public IPs to nodes?

@feiskyer
Copy link
Member Author

feiskyer commented Mar 9, 2018

While the code is good to go (specially in case of current node). I am not sure if we should assign public/external IPs to nodes. Do we assign public IPs to nodes?

acs-engine or aks won't do this. It determines to users. If users assigned a public IP, then it should be included in node's addresses (we have already done this with UseInstanceMetadata=true).

@khenidak
Copy link
Contributor

khenidak commented Mar 9, 2018

That is correct.
/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, khenidak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer feiskyer added this to the v1.10 milestone Mar 9, 2018
@feiskyer feiskyer added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 9, 2018
@feiskyer
Copy link
Member Author

feiskyer commented Mar 9, 2018 •
edited
Loading

Added to v1.10 milestone since it is a bug fix. cc @jdumars

@feiskyer
Copy link
Member Author

feiskyer commented Mar 9, 2018

/status approved-for-milestone

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@feiskyer @khenidak

Pull Request Labels
  • sig/azure: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 17d69c2 into kubernetes:master Mar 9, 2018
@feiskyer feiskyer deleted the external-ip branch March 9, 2018 06:36
This was referenced Mar 12, 2018
Merged
Merged
@jdumars
Copy link
Member

jdumars commented Mar 12, 2018

FYI @mbohlool @jpbetz this is a high priority cherry pick going to 1.9.x and 1.8.x

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

k8s-github-robot pushed a commit that referenced this pull request Mar 14, 2018
Merge pull request #61024 from feiskyer/automated-cherry-pick-of-#609…
374eb74 
…59-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #60959: Set node external IP for azure node when disabling UseInstanceMetadata

Cherry pick of #60959 on release-1.8.

#60959: Set node external IP for azure node when disabling UseInstanceMetadata
k8s-github-robot pushed a commit that referenced this pull request Mar 14, 2018
Merge pull request #61023 from feiskyer/automated-cherry-pick-of-#609…
42b589d 
…59-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #60959: Set node external IP for azure node when disabling UseInstanceMetadata

Cherry pick of #60959 on release-1.9.

#60959: Set node external IP for azure node when disabling UseInstanceMetadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@khenidak khenidak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

Node external IP is not set when disabling useInstanceMetadata
7 participants
@feiskyer @andyzhangx @khenidak @k8s-ci-robot @k8s-github-robot @jdumars @k8s-cherrypick-bot