Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Reachable Condition #6094

Merged
merged 1 commit into from
Apr 1, 2015
Merged

Remove Reachable Condition #6094

merged 1 commit into from
Apr 1, 2015

Conversation

ddysher
Copy link
Contributor

@ddysher ddysher commented Mar 27, 2015

@davidopp davidopp self-assigned this Mar 30, 2015
@ddysher ddysher force-pushed the remove-reachability branch from d2edd3c to 50685da Compare March 30, 2015 14:27
@bgrant0607 bgrant0607 assigned bgrant0607 and unassigned davidopp Apr 1, 2015
@bgrant0607
Copy link
Member

Thanks. LGTM, but please rebase and regenerate the swagger.

@ddysher ddysher force-pushed the remove-reachability branch from 50685da to 5745b5b Compare April 1, 2015 13:46
@ddysher
Copy link
Contributor Author

ddysher commented Apr 1, 2015

Rebased and regenerated swagger.

@bgrant0607
Copy link
Member

Hmm. The generated swagger is not correct. I suggest reverting those files and we'll figure out the problem in a subsequent PR.

@ddysher ddysher force-pushed the remove-reachability branch from 5745b5b to 6bb9701 Compare April 1, 2015 17:56
@ddysher
Copy link
Contributor Author

ddysher commented Apr 1, 2015

I've clean up my repo and regenerated swagger. Please take another look if these are correct (it looks correct now). If not, I'll revert then.

@bgrant0607
Copy link
Member

Those look similar to the changes in #6232. @nikhiljindal which version is correct? Maybe an outdated version was merged.

@nikhiljindal
Copy link
Contributor

Looks like we didnt upgrade swagger spec after #6143 and #6117.
The type changes (bool to boolean) and addition of path parameter are surely due to those PRs.

@bgrant0607
Copy link
Member

Ok, thanks.

bgrant0607 added a commit that referenced this pull request Apr 1, 2015
@bgrant0607
Merge pull request #6094 from ddysher/remove-reachability
7450da4 
Remove Reachable Condition
@bgrant0607 bgrant0607 merged commit 7450da4 into kubernetes:master Apr 1, 2015
@ddysher ddysher mentioned this pull request Apr 2, 2015
Closed
@ddysher ddysher deleted the remove-reachability branch March 13, 2016 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ddysher @bgrant0607 @nikhiljindal @googlebot @davidopp