Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e/monitoring: Use non-deprecated proxy API #60921

Merged
merged 2 commits into from
Mar 15, 2018
Merged

e2e/monitoring: Use non-deprecated proxy API #60921

merged 2 commits into from
Mar 15, 2018

Conversation

brancz
Copy link
Member

@brancz brancz commented Mar 8, 2018 •
edited
Loading

What this PR does / why we need it:

In Kubernetes 1.10 this API is removed, which causes upgrade tests to
fail, as the deprecated, but in 1.10 removed API is used here.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #60768

Special notes for your reviewer:

I'm not sure whether the upgrade tests are run from HEAD of 1.9 branch or from the latest release, if it's from the latest release, then we need a 1.9.x patch release for the upgrade test to be fixed.

cc @mbohlool (this is my first time doing this so I may have done something completely wrong, please tell me if I did do so 🙂)

@brancz
e2e/monitoring: Use non-deprecated proxy API
9906e4e 
In Kubernetes 1.10 this API is removed, which causes upgrade tests to
fail, as the deprecated, but in 1.10 removed API is used here.
@k8s-ci-robot
Copy link
Contributor

@brancz: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 8, 2018
@k8s-ci-robot k8s-ci-robot requested review from kow3ns and ncdc March 8, 2018 11:10
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 8, 2018
@brancz brancz mentioned this pull request Mar 8, 2018
Closed
@brancz
Copy link
Member Author

brancz commented Mar 8, 2018

/test pull-kubernetes-kubemark-e2e-gce

1 similar comment
@brancz
Copy link
Member Author

brancz commented Mar 8, 2018

/test pull-kubernetes-kubemark-e2e-gce

@brancz brancz mentioned this pull request Mar 8, 2018
Closed
@brancz
Copy link
Member Author

brancz commented Mar 8, 2018

I believe the same as in #60872 might have been the problem, so I cherry-picked it to validate this.

@liggitt
Copy link
Member

liggitt commented Mar 8, 2018 •
edited
Loading

More changes are needed to fix uses of the deprecated proxy endpoints (there are actual proxy tests that need to be version gated… see #60769).

The 1.9 branch is actually frozen at the moment as well preparing for a release

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2018
@brancz
Copy link
Member Author

brancz commented Mar 8, 2018

I would suggest that to be done in a separate PR, as I have little idea about what needs to be done for that.

@liggitt
Copy link
Member

liggitt commented Mar 8, 2018

Fair enough. Will cancel hold once the branch is open.

@liggitt
Copy link
Member

liggitt commented Mar 13, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2018
@liggitt liggitt added this to the v1.9 milestone Mar 13, 2018
@liggitt
Copy link
Member

liggitt commented Mar 13, 2018

cc @kubernetes/sig-testing-pr-reviews @kubernetes/sig-release-pr-reviews

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 13, 2018
@liggitt
Copy link
Member

liggitt commented Mar 13, 2018

/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Mar 13, 2018
@liggitt
Copy link
Member

liggitt commented Mar 13, 2018

/lgtm
/status approved-for-milestone
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. status/approved-for-milestone lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 13, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@brancz @liggitt

Pull Request Labels
  • sig/release sig/testing: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@liggitt
Copy link
Member

liggitt commented Mar 13, 2018

the purge all the -v references from e2e.go commit was already merged in #60940, this is only changing to use the non-deprecated proxy endpoint

@ixdy
Copy link
Member

ixdy commented Mar 13, 2018

does this need a rebase to make github drop the purge all the -v references from e2e.go commit?

@liggitt
Copy link
Member

liggitt commented Mar 13, 2018

does this need a rebase to make github drop the purge all the -v references from e2e.go commit?

not necessary. git will drop it when it merges the PR into the release branch

@cblecker
Copy link
Member

Yup. I confirmed this is what would happen locally.
/approve

@liggitt
Copy link
Member

liggitt commented Mar 13, 2018

I confirmed this is what would happen locally.

O ye of little faith

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, cblecker, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2018
@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 13, 2018
@jdumars
Copy link
Member

jdumars commented Mar 14, 2018

@jpbetz PTAL

@liggitt
Copy link
Member

liggitt commented Mar 15, 2018

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@liggitt
Copy link
Member

liggitt commented Mar 15, 2018

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@liggitt
Copy link
Member

liggitt commented Mar 15, 2018

flaked on #61230

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit e4393c2 into kubernetes:release-1.9 Mar 15, 2018
@brancz brancz deleted the new-proxy-api branch March 16, 2018 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kow3ns kow3ns Awaiting requested review from kow3ns

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
10 participants
@brancz @k8s-ci-robot @liggitt @k8s-github-robot @ixdy @cblecker @jdumars @fejta-bot @mbohlool @krzyzacy