Write the json content type for API responses #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,6 +62,21 @@ func NewNotFoundErr(kind, name string) error { | |||
| return errNotFound(fmt.Sprintf("%s %q not found", kind, name)) | |||
| } | |||
|
|
|||
| type errAlreadyExists string | |||
There was a problem hiding this comment.
Two thoughts--
Does this type belong in this PR?
If yes, can you generalize this type with the errNotFound type instead of making them distinct types? (e.g., have an httpResponseCode which is 404 for MakeNotFound and 409 (?) for MakeAlreadyExists...
There was a problem hiding this comment.
It does not - my bad.
There was a problem hiding this comment.
I will do the generalization with another issue - that's coming from some other prototyping I was doing and mixed my commits.
lavalamp
added a commit
that referenced
this pull request
Jul 24, 2014
Write the json content type for API responses
|
Thanks! |
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Dec 8, 2016
Fix nginx buffering bug
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Mar 3, 2017
Fix nginx buffering bug
wking
pushed a commit
to wking/kubernetes
that referenced
this pull request
Jul 21, 2020
add google analytics to kubectl book
linxiulei
pushed a commit
to linxiulei/kubernetes
that referenced
this pull request
Jan 18, 2024
Create cloudbuild file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #604