Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #60625 #60677

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Automated cherry pick of #60625 #60677

merged 1 commit into from
Mar 22, 2018

Conversation

andyzhangx
Copy link
Member

Cherry pick of #60625 on release-1.9.

#60625: add remount logic for azure file plugin

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 2, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 2, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 2, 2018
@andyzhangx
Copy link
Member Author

/assign @feiskyer

@feiskyer
Copy link
Member

feiskyer commented Mar 2, 2018

@andyzhangx bazel failed. Have you run update-bazel.sh locally?

@mbohlool
Copy link
Contributor

mbohlool commented Mar 2, 2018

how is this tested?

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-verify

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-integration

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws

@andyzhangx
Copy link
Member Author

Hi @mbohlool I did the manual test, restart windows node to verify whether pod could access original azure file. Currently there is no e2e test on Windows node, we will add such e2e test in the future.

@andyzhangx
Copy link
Member Author

@feiskyer It's a random failure, something wrong with bazel verify tool.

feiskyer
feiskyer reviewed Mar 4, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mbohlool
Copy link
Contributor

mbohlool commented Mar 5, 2018

The branch is frozen. holding this for 1.9.5.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2018
@thockin
Copy link
Member

thockin commented Mar 5, 2018

This change is Reviewable

@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 13, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@jpbetz
Copy link
Contributor

jpbetz commented Mar 18, 2018

/hold
Hold all unmerged cherrypicks for cut of patch release on Monday.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2018
@jpbetz jpbetz removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 3cd74e3 into kubernetes:release-1.9 Mar 22, 2018
@andyzhangx andyzhangx deleted the automated-cherry-pick-of-#60625-upstream-release-1.9 branch May 8, 2018 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@andyzhangx @feiskyer @mbohlool @k8s-ci-robot @thockin @fejta-bot @jpbetz @k8s-github-robot