Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet: notify systemd that kubelet has started #60654

Merged
merged 1 commit into from
Mar 3, 2018
Merged

kubelet: notify systemd that kubelet has started #60654

merged 1 commit into from
Mar 3, 2018
+18 −1

Conversation

dcbw
Copy link
Member

@dcbw dcbw commented Mar 1, 2018

This call has no side-effects if systemd is not used or not installed.

Fixes: #59079

@smarterclayton @sjenning

kubelet now notifies systemd that it has finished starting, if systemd is available and running.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2018
@dcbw dcbw mentioned this pull request Mar 1, 2018
Closed
@dcbw dcbw added this to the v1.10 milestone Mar 1, 2018
@dcbw dcbw added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 1, 2018
@dashpole dashpole mentioned this pull request Mar 1, 2018
Closed
@smarterclayton
Copy link
Contributor

Hrm - I put mine right where the sync loop started.

@dcbw
kubelet: notify systemd that kubelet has started
394d928 
The notify call has no side-effects if systemd is not used or
not installed.

Fixes: kubernetes#59079
@dcbw dcbw force-pushed the kubelet-notify-systemd branch from 20c9b16 to 394d928 Compare March 2, 2018 17:02
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 2, 2018
@smarterclayton
Copy link
Contributor

This is fine

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2018
@smarterclayton smarterclayton added status/approved-for-milestone and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 2, 2018
@smarterclayton smarterclayton added kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 3, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@dcbw @smarterclayton

Pull Request Labels
  • sig/node: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit c6d0726 into kubernetes:master Mar 3, 2018
@sjenning sjenning mentioned this pull request Apr 10, 2018
Closed
@linxiulei linxiulei mentioned this pull request Jan 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@resouer resouer Awaiting requested review from resouer

Assignees

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
5 participants
@dcbw @smarterclayton @k8s-ci-robot @k8s-github-robot @fejta-bot