Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default vmtype to standard if not set #60623

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Set default vmtype to standard if not set #60623

merged 1 commit into from
Mar 1, 2018
+6 −0

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Mar 1, 2018 •
edited
Loading

What this PR does / why we need it:

When using IMDS, kubelet reports Failed to extract vmssVMName even when vmtype is not set:

E0301 05:30:57.515306    3124 azure_vmss_cache.go:52] Failed to extract vmssVMName "77890k8s9010"
E0301 05:30:57.515306    3124 kubelet_node_status.go:79] Unable to construct v1.Node object for kubelet: failed to get external ID from cloud provider: not a vmss instance

azure cloud provider shouldn't call vmss logic in this case. It should assume stardard vmtype if it is not set.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #60622

Special notes for your reviewer:

Release note:

Set Azure vmType to standard if it is not set in azure cloud config.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 1, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2018
@feiskyer feiskyer added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Mar 1, 2018
@feiskyer feiskyer added this to the v1.10 milestone Mar 1, 2018
@feiskyer
Copy link
Member Author

feiskyer commented Mar 1, 2018

Added to v1.10 milestone since it is a critical bug fix.

cc @jdumars

@feiskyer feiskyer requested a review from andyzhangx March 1, 2018 05:57
andyzhangx
andyzhangx approved these changes Mar 1, 2018
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 60623, 60625, 60520). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 9399359 into kubernetes:master Mar 1, 2018
@feiskyer feiskyer deleted the vmtype branch March 1, 2018 23:22
@wojtek-t wojtek-t mentioned this pull request Apr 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@jdumars jdumars jdumars approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

Failed to extract vmssVMName for azure nodes
5 participants
@feiskyer @k8s-ci-robot @k8s-github-robot @jdumars @andyzhangx