Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax time tolerance on KMS test, limit to platforms with unix sockets available #60615

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Relax time tolerance on KMS test, limit to platforms with unix sockets available #60615

merged 1 commit into from
Mar 1, 2018
+157 −11

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 1, 2018 •
edited
Loading

Fixes #60613
Fixes #60614

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 1, 2018
@liggitt liggitt force-pushed the deflake-kms-test branch from b1c8de1 to ed2f4e0 Compare March 1, 2018 03:42
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 1, 2018
@liggitt
Copy link
Member Author

liggitt commented Mar 1, 2018

cc @BenTheElder

BenTheElder
BenTheElder approved these changes Mar 1, 2018
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt mentioned this pull request Mar 1, 2018
Closed
@BenTheElder
Copy link
Member

Technically only flaking, but I think this is still appropriate?
/priority failing-test

@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Mar 1, 2018
@liggitt
Copy link
Member Author

liggitt commented Mar 1, 2018

verified TestKMSProvider still ran in integration test

adding to milestone, test-only change, helps stabilize CI

@liggitt liggitt added this to the v1.10 milestone Mar 1, 2018
@liggitt
Copy link
Member Author

liggitt commented Mar 1, 2018

@kubernetes/sig-api-machinery-test-failures

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 1, 2018
@BenTheElder
Copy link
Member

/test pull-kubernetes-typecheck

@liggitt
Copy link
Member Author

liggitt commented Mar 1, 2018

/status approved-for-milestone

@liggitt liggitt added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Mar 1, 2018
@BenTheElder
Copy link
Member

🎉 green run of the cross typecheck @rmmh

@immutableT immutableT mentioned this pull request Mar 1, 2018
Closed
@dims
Copy link
Member

dims commented Mar 1, 2018

LGTM 👍

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 51216e0 into kubernetes:master Mar 1, 2018
@liggitt liggitt deleted the deflake-kms-test branch March 12, 2018 05:24
@wojtek-t wojtek-t mentioned this pull request Apr 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@madhusudancs madhusudancs Awaiting requested review from madhusudancs

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
5 participants
@liggitt @k8s-ci-robot @BenTheElder @dims @k8s-github-robot