[ubuntu-cluster] fix a serious bug when node both act as master and minion #6060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
@WIZARD-CXY CLA is not good, please fix it @googlebot |
|
This LGTM, CLA is ok for @WIZARD-CXY, since there has previous commits. Merging. |
brendandburns
added a commit
that referenced
this pull request
Mar 27, 2015
[ubuntu-cluster] fix a serious bug when node both act as master and minion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a serious bug (a extra comma) may break the ubuntu-cluster install process when a node acts both as master and minion.
We are still working on PR #5498 based on advices from @rjnagal. In order to make ubuntu-cluster fully automatically. But we hope owners can merge this PR first, for usage consideration.