Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix todo:Get rid of this duplicate function IsRetryableAPIError in favour of the one in test/utils #60557

Merged
merged 1 commit into from
Mar 1, 2018
Merged

fix todo:Get rid of this duplicate function IsRetryableAPIError in favour of the one in test/utils #60557

merged 1 commit into from
Mar 1, 2018

Conversation

hanxiaoshuai
Copy link
Contributor

@hanxiaoshuai hanxiaoshuai commented Feb 28, 2018 •
edited
Loading

What this PR does / why we need it:
fix todo:Get rid of this duplicate function IsRetryableAPIError in favour of the one in test/utils
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 28, 2018
@fisherxu
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 28, 2018
@hanxiaoshuai
Copy link
Contributor Author

/test pull-kubernetes-node-e2e

@wojtek-t
Copy link
Member

/assign shyamjvs

@shyamjvs
Copy link
Member

Thanks for the cleanup @hanxiaoshuai !
Could you please rebase?

@shyamjvs shyamjvs added this to the v1.10 milestone Feb 28, 2018
@shyamjvs
Copy link
Member

@jdumars Could you please /approved-for-milestone this PR? It's just a testing cleanup.

@jdumars
Copy link
Member

jdumars commented Feb 28, 2018

@shyamjvs done. Should be good to go once you rebase.

@hanxiaoshuai
Copy link
Contributor Author

@shyamjvs I have rebased , Thanks

@wojtek-t
Copy link
Member

wojtek-t commented Mar 1, 2018

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanxiaoshuai, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 875f8c3 into kubernetes:master Mar 1, 2018
@wojtek-t wojtek-t mentioned this pull request Apr 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@shyamjvs shyamjvs

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
7 participants
@hanxiaoshuai @fisherxu @wojtek-t @shyamjvs @jdumars @k8s-ci-robot @k8s-github-robot