Do not fail pod status update if failed to get host IP #6054
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
zmerlynn
added
the
lgtm
| @@ -1924,9 +1924,10 @@ func (kl *Kubelet) generatePodStatusByPod(pod *api.Pod) (api.PodStatus, error) { | |||
| podStatus.Host = kl.GetHostname() | |||
| hostIP, err := kl.GetHostIP() | |||
| if err != nil { | |||
| return api.PodStatus{}, fmt.Errorf("Cannot get host IP: %v", err) | |||
| glog.Errorf("Cannot get host IP: %v", err) | |||
There was a problem hiding this comment.
nit: Can specify for what pod?
|
LGTM, build is green. |
vmarmol
added a commit
that referenced
this pull request
Mar 27, 2015
Do not fail pod status update if failed to get host IP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar how it used work in pod_cache.
This fixes #6046
@dchen1107