Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change regional PD cloud provider references to use the beta API #60450

Merged
merged 2 commits into from
Mar 9, 2018
Merged

Change regional PD cloud provider references to use the beta API #60450

merged 2 commits into from
Mar 9, 2018

Conversation

verult
Copy link
Contributor

@verult verult commented Feb 26, 2018

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #59988

Special notes for your reviewer: Depends on a version of the GCP Go beta compute client that is not yet available. Also need to rebase with #60337 once it's merged.

/hold
/cc @abgworrall
/assign @saad-ali

@k8s-ci-robot
Copy link
Contributor

@verult: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2018
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 26, 2018
@verult
Copy link
Contributor Author

verult commented Feb 26, 2018

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 26, 2018
@saad-ali saad-ali added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/gcp kind/feature Categorizes issue or PR as related to a new feature. labels Feb 26, 2018
@saad-ali saad-ali added this to the v1.10 milestone Feb 26, 2018
@jberkus
Copy link

jberkus commented Feb 28, 2018

@saad-ali if this PR is going to be in 1.10, then it needs status/approved-for-milestone. Also daily updates on progress. Thanks!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2018
@verult
Copy link
Contributor Author

verult commented Mar 1, 2018

Currently we are waiting for a version of the GCP Go beta compute client scheduled to be available on Saturday, 3/4.

@thockin
Copy link
Member

thockin commented Mar 5, 2018

This change is Reviewable

@verult verult mentioned this pull request Mar 5, 2018
Closed
@verult verult force-pushed the repd-beta-integration branch from 618bd71 to df3d8bc Compare March 7, 2018 22:47
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2018
@verult
Copy link
Contributor Author

verult commented Mar 7, 2018

Integrated with up-to-date client, which is added as a separate commit.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 7, 2018 •
edited
Loading

@verult: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit 618bd71 link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@verult
Copy link
Contributor Author

verult commented Mar 8, 2018

/retest

@verult
Copy link
Contributor Author

verult commented Mar 8, 2018

/cc @thockin @bowei
for GCE go client vendor review

@k8s-ci-robot k8s-ci-robot requested a review from bowei March 8, 2018 00:26
@k8s-ci-robot k8s-ci-robot requested a review from thockin March 8, 2018 00:26
@saad-ali
Copy link
Member

saad-ali commented Mar 8, 2018

/lgtm
/approve

For vendor dir approval
/assign @thockin

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@saad-ali @thockin @verult

Pull Request Labels
  • sig/gcp sig/storage: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/feature: New functionality.
Help

@verult
Copy link
Contributor Author

verult commented Mar 8, 2018

Ran regional PD tests repeatedly on a multizonal cluster. Verified the following tests on single-zone clusters to catch potential regressions:
Persistent Volumes GCE
Volume Provisioning
PD tests
Also verified PV GCE and Volume Provisioning tests on a multizone cluster.

@thockin
Copy link
Member

thockin commented Mar 8, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, thockin, verult

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2018
@saad-ali saad-ali removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 8f82016 into kubernetes:master Mar 9, 2018
@verult verult deleted the repd-beta-integration branch March 24, 2018 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abgworrall abgworrall

@bowei bowei

@thockin thockin

Assignees

@thockin thockin

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

Improve k8s support for multizone PDs.
6 participants
@verult @k8s-ci-robot @jberkus @thockin @saad-ali @k8s-github-robot