Deprecate kubectl scale job #60139
Deprecate kubectl scale job #60139
Conversation
k8s-ci-robot
added
release-note
|
This matches the discussion in sig-cli. /lgtm |
k8s-ci-robot
added
lgtm
pkg/kubectl/cmd/scale.go
Outdated
| @@ -146,6 +147,10 @@ func RunScale(f cmdutil.Factory, out io.Writer, cmd *cobra.Command, args []strin | |||
| } | |||
|
|
|||
| mapping := info.ResourceMapping() | |||
| if mapping.Resource == "jobs" { | |||
| glog.Warningf("%s scale job is DEPRECATED and will be removed in a future version.", cmd.Parent().Name()) | |||
There was a problem hiding this comment.
we normally use fmt.fprintf(stderr to avoid irrelevant line numbers.
There was a problem hiding this comment.
That's what I had originally, but then I found this cherry. Although I'm fine fixing the other one as well to use fmt.Fprintf
|
/hold fix up the printing |
k8s-ci-robot
added
the
do-not-merge/hold
soltysh
force-pushed
the
deprecate_scale_job
branch
from
676ab52 to
2935fd6
Compare
k8s-ci-robot
added
size/M
k8s-github-robot
removed
the
lgtm
|
@deads2k fixed the printing and updated |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The printing was fixed, I'm guessing David forgot to : |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
With the generic scaler (#58298) the only problem is job and as discussed in #58468 (comment) and during SIG CLI we've agreed that scaling jobs was a mistake we need to revert.
This PR deprecates scale command for jobs, only.
/assign @deads2k @pwittrock
Release note: