Add Garbage Collector e2e conformance tests #60116
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/architecture
|
/assign @caesarxuchao cc @wenjiaswe |
|
@kubernetes/sig-architecture-pr-reviews |
|
@jennybuckley It's reasonable to add these tests to the conformance suite, since the functionality is now GA. However, the tests need names and descriptions in comments. Search the repo for "ConformanceIt" for examples. |
jennybuckley
force-pushed
the
gc-conf-test
branch
from
b12eb9a to
b784ff6
Compare
k8s-ci-robot
added
size/M
| It("should orphan RS created by deployment when deleteOptions.OrphanDependents is true", func() { | ||
| /* | ||
| Testname: garbage-collector-delete-deployment-orphaning-true | ||
| Description: Ensure that if deleteOptions.OrphanDependents is set to false, |
|
|
||
| /* | ||
| Testname: garbage-collector-delete-rc-orphaning-false | ||
| Description: Ensure that if deleteOptions.OrphanDependents is set to false, |
There was a problem hiding this comment.
OrphanDependents is deprecated. We should update the test to use deleteOptions.PropagationPolicy (https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/types.go#L455). Could you update the test to use the getBackgroundOptions() instead of getNonOrphanOptions()? That's just an API change, shouldn't cause any behavior change.
| It("should keep the rc around until all its pods are deleted if the deleteOptions says so", func() { | ||
| /* | ||
| Testname: garbage-collector-delete-rc-after-owned-pods | ||
| Description: Ensure that if deleteOptions.OrphanDependents is set to false, |
There was a problem hiding this comment.
Ensure that if deleteOptions.propagationPolicy="Foreground", ...
| It("should not delete dependents that have both valid owner and owner that's waiting for dependents to be deleted", func() { | ||
| /* | ||
| Testname: garbage-collector-multiple-owners | ||
| Description: Ensure that if deleteOptions.PropogationPolicy is set to |
There was a problem hiding this comment.
Could you update the description to match the description in "ConformanceIt"?
| It("should orphan pods created by rc if delete options say so", func() { | ||
| /* | ||
| Testname: garbage-collector-delete-rc-orphaning-true | ||
| Description: Ensure that if deleteOptions.OrphanDependents is set to true, |
There was a problem hiding this comment.
ditto. Please update the test to use DeletePropagationOrphan.
| It("should orphan pods created by rc if deleteOptions.OrphanDependents is nil", func() { | ||
| /* | ||
| Testname: garbage-collector-delete-rc-orphaning-unset | ||
| Description: Ensure that if deleteOptions.OrphanDependents is set to nil, |
There was a problem hiding this comment.
This just requires a change in the comment. Both OrphanDependents and PropagationPolicy are default to nil.
| It("should delete RS created by deployment when not orphaning", func() { | ||
| /* | ||
| Testname: garbage-collector-delete-deployment-orphaning-false | ||
| Description: Ensure that if deleteOptions.OrphanDependents is set to false, |
There was a problem hiding this comment.
Please update to DeletePropagationBackground.
| It("should orphan RS created by deployment when deleteOptions.OrphanDependents is true", func() { | ||
| /* | ||
| Testname: garbage-collector-delete-deployment-orphaning-true | ||
| Description: Ensure that if deleteOptions.OrphanDependents is set to false, |
There was a problem hiding this comment.
Please use DeletePropagationOrphan policy.
|
Tests using deprecated features should not be added to conformance. |
jennybuckley
force-pushed
the
gc-conf-test
branch
from
b784ff6 to
e6f867d
Compare
|
Thanks. I'll wait for @caesarxuchao to re-review before approving. Conformance should test GA, non-deprecated features. |
|
/test pull-kubernetes-verify |
|
I think https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/60116/pull-kubernetes-verify/79482/ is not a legitimate failure. All PRs seem to be failing the same way |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
All the tested features here have been stable for more than 1 year. GC of custom resources have flakeness in tests but they are not tested here. |
|
FYI, some tests failed. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgrant0607, caesarxuchao, jennybuckley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
#60442 just merged /test pull-kubernetes-verify |
|
/test pull-kubernetes-e2e-gce-device-plugin-gpu |
|
Automatic merge from submit-queue (batch tested with PRs 60430, 60115, 58052, 60355, 60116). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
The garbage collector is a core component of kubernetes and needs to be tested by conformance, so its functionality can be relied on in any kubernetes environment.
As we can see in testgrid, the garbage collector tests being promoted by this PR are consistently passing. And the intention to promote them to conformance tests was laid out by this document
Special notes for your reviewer:
The last two tests in this file are not added as conformance tests because they involve beta features (custom resources and cronjobs), and conformance tests are only allowed for features in GA.
Release note: