Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AllowVolumeExpansion field to storageclass describe #60032

Merged
merged 1 commit into from
Feb 20, 2018
Merged

AllowVolumeExpansion field to storageclass describe #60032

merged 1 commit into from
Feb 20, 2018
+1 −0

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Feb 19, 2018

Signed-off-by: Humble Chirammal hchiramm@redhat.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

@humblec
AllowVolumExpansion field to describe printer.
0512d03 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 19, 2018
@humblec humblec changed the title AllowVolumExpansion field to describe printer. AllowVolumExpansion field to stroageclass describe Feb 19, 2018
@humblec
Copy link
Contributor Author

humblec commented Feb 19, 2018

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 19, 2018
@humblec
Copy link
Contributor Author

humblec commented Feb 19, 2018 •
edited
Loading

/assign @jsafrane

@humblec
Copy link
Contributor Author

humblec commented Feb 19, 2018

@eparis Can you please review ? :)

@humblec
Copy link
Contributor Author

humblec commented Feb 20, 2018

/assign @eparis @smarterclayton

@eparis
Copy link
Contributor

eparis commented Feb 20, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2018
@humblec humblec changed the title AllowVolumExpansion field to stroageclass describe AllowVolumeExpansion field to stroageclass describe Feb 20, 2018
@humblec humblec changed the title AllowVolumeExpansion field to stroageclass describe AllowVolumeExpansion field to storageclass describe Feb 20, 2018
@smarterclayton
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, humblec, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 59634, 59821, 57850, 59916, 60032). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 6235a60 into kubernetes:master Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eparis eparis Awaiting requested review from eparis

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@smarterclayton smarterclayton

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@humblec @eparis @smarterclayton @k8s-ci-robot @k8s-github-robot @fejta-bot