Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "add node shutdown taint" #59968

Merged
merged 1 commit into from
Feb 17, 2018
Merged

Revert "add node shutdown taint" #59968

merged 1 commit into from
Feb 17, 2018

Conversation

aleksandra-malinowska
Copy link
Contributor

@aleksandra-malinowska aleksandra-malinowska commented Feb 16, 2018 •
edited by gmarek
Loading

Reverts #59323

Node becomes unready, but is never removed. I've found the following in kube-controller-manager.log from test run for one such node:

E0216 01:14:27.084923 1 node_lifecycle_controller.go:686] Error determining if node bootstrap-e2e-minion-group-01b1 shutdown in cloud: failed to get instance ID from cloud provider: instance not found

This goes on for the rest of the run (~6h). Looks like the node is stuck in Unready state because of this check: https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/nodelifecycle/node_lifecycle_controller.go#L684. Previously, there was no such check and the node was removed.

Reverting as this would affect all users attempting to resize their node groups on GCE.

NONE

@aleksandra-malinowska aleksandra-malinowska added kind/bug Categorizes issue or PR as related to a bug. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 16, 2018
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 16, 2018
@aleksandra-malinowska aleksandra-malinowska added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 16, 2018
@aleksandra-malinowska
Copy link
Contributor Author

@k8s-ci-robot k8s-ci-robot requested review from anguslees, brendandburns, davidopp, jingxu97, thockin and zmerlynn a minute ago

No idea why the bot added so many people - sorry for the noise.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 16, 2018
@aleksandra-malinowska aleksandra-malinowska added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 16, 2018
@zetaab
Copy link
Member

zetaab commented Feb 16, 2018

/approve

like i wrote in that PR

@aleksandra-malinowska, right its bug. Here https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/nodelifecycle/node_lifecycle_controller.go#L685 here we ignore only cloudprovider.NotImplemented error. However, there can be other errors as well which should be ignored https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/util/node/controller_utils.go#L199

so lets revert this and modify that little bit

@zetaab
Copy link
Member

zetaab commented Feb 16, 2018 •
edited
Loading

possible fix zetaab@499b78a

@aleksandra-malinowska
Copy link
Contributor Author

/retest

@aleksandra-malinowska
Copy link
Contributor Author

@zetaab Thanks for quick response. Let's proceed with the revert then.

@aleksandra-malinowska aleksandra-malinowska removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 16, 2018
@yastij
Copy link
Member

yastij commented Feb 16, 2018

cc @gmarek @jingxu97

@gmarek
Copy link
Contributor

gmarek commented Feb 16, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2018
@dims
Copy link
Member

dims commented Feb 16, 2018

/approve
/lgtm

@yastij
Copy link
Member

yastij commented Feb 16, 2018

cc @timothysc

@gmarek
Copy link
Contributor

gmarek commented Feb 16, 2018

@smarterclayton - can you approve this?

@timothysc
Copy link
Member

Only someone with higher cross directory OWNER privs can approve this one.

/cc @smarterclayton @wojtek-t

@bsalamat
Copy link
Member

/lgtm

@dims dims mentioned this pull request Feb 17, 2018
Merged
@mikedanese
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleksandra-malinowska, bsalamat, dims, gmarek, mikedanese, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2018
@Random-Liu
Copy link
Member

Possibly related to #59994?

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 6d0b717 into master Feb 17, 2018
@mikedanese mikedanese deleted the revert-59323-nodetaint branch February 17, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yastij yastij yastij approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@bsalamat bsalamat Awaiting requested review from bsalamat

@k82cn k82cn Awaiting requested review from k82cn

@anguslees anguslees Awaiting requested review from anguslees

@brendandburns brendandburns Awaiting requested review from brendandburns

@davidopp davidopp Awaiting requested review from davidopp

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@thockin thockin Awaiting requested review from thockin

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dims dims

@gmarek gmarek

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.