Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start deprecation of role for cloud-provider service account in rbac boostrap #59949

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Start deprecation of role for cloud-provider service account in rbac boostrap #59949

merged 1 commit into from
Feb 22, 2018

Conversation

nicksardo
Copy link
Contributor

@nicksardo nicksardo commented Feb 15, 2018 •
edited
Loading

What this PR does / why we need it:
See #59686 for reference

Special notes for your reviewer:
/assign @tallclair

Release note:

Action Required: The boostrapped RBAC role and rolebinding for the `cloud-provider` service account is now deprecated. If you're currently using this service account, you must create and apply your own RBAC policy for new clusters.

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 15, 2018
@k8s-ci-robot k8s-ci-robot requested review from enj and liggitt February 15, 2018 22:38
@nicksardo nicksardo mentioned this pull request Feb 15, 2018
Merged
@nicksardo
Copy link
Contributor Author

Note that this doesn't deprecate aws-cloud-provider. @gnufied, any plans to move out of the boostrap?

@tallclair
Copy link
Member

The release note says action required, but not what the action is. I'd suggest linking to the manifests that replace those roles, or stating that the roles must be setup through other means if the user wants to keep using them.

@nicksardo
Copy link
Contributor Author

Updated. Thanks

@tallclair
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2018
@nicksardo
Copy link
Contributor Author

/assign @liggitt
PTAL

@liggitt
Copy link
Member

liggitt commented Feb 21, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, nicksardo, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 59052, 59157, 59428, 59949, 60151). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 34167de into kubernetes:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj Awaiting requested review from enj

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicksardo @tallclair @liggitt @k8s-ci-robot @k8s-github-robot