Move ipvs module loading logic in local-cluster-up.sh #59936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/cc @dims |
|
/assign @m1093782566 |
dims
reviewed
Feb 15, 2018
hack/local-up-cluster.sh
Outdated
| then | ||
| FEATURE_GATES="$FEATURE_GATES,SupportIPVSProxyMode=true" | ||
| else | ||
| KUBE_PROXY_MODE=iptables |
There was a problem hiding this comment.
would be helpful to log a message that we are falling back to iptables mode
rramkumar1
force-pushed
the
local-up-cluster-ipvs
branch
from
65fea60 to
512c136
Compare
cblecker
reviewed
Feb 16, 2018
hack/local-up-cluster.sh
Outdated
| FEATURE_GATES="$FEATURE_GATES,SupportIPVSProxyMode=true" | ||
| # If required kernel modules are not available, fall back to iptables. | ||
| sudo modprobe -a ip_vs ip_vs_rr ip_vs_wrr ip_vs_sh nf_conntrack_ipv4 | ||
| if [[ $? -eq 0 ]]; |
hack/local-up-cluster.sh
Outdated
| sudo modprobe -a ip_vs ip_vs_rr ip_vs_wrr ip_vs_sh nf_conntrack_ipv4 | ||
| if [[ $? -eq 0 ]]; | ||
| then | ||
| FEATURE_GATES="$FEATURE_GATES,SupportIPVSProxyMode=true" |
There was a problem hiding this comment.
nit:
FEATURE_GATES="${FEATURE_GATES},SupportIPVSProxyMode=true"
rramkumar1
force-pushed
the
local-up-cluster-ipvs
branch
from
512c136 to
ab53cb2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, rramkumar1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 59683, 59964, 59841, 59936, 59686). If you want to cherry-pick this change to another branch, please follow the instructions here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes the module loading logic for ipvs kube-proxy a little more robust. Previously we were attempting to load the modules and not checking that it succeeded. Now we make sure the loading was successful before proceeding with using ipvs as the proxier.
/assign @cblecker
Release Note