Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated /proxy paths #59884

Merged
merged 2 commits into from
Feb 21, 2018
Merged

remove deprecated /proxy paths #59884

merged 2 commits into from
Feb 21, 2018

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese commented Feb 14, 2018 •
edited by liggitt
Loading

These were deprecated in v1.2.
ref #59885

kube-apiserver: the root /proxy paths have been removed (deprecated since v1.2). Use the /proxy subresources on objects that support HTTP proxying.

@kubernetes/sig-api-machinery-api-reviews

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 14, 2018
@mikedanese mikedanese force-pushed the remove-deprecated-proxy branch from a82f3da to 97127f7 Compare February 14, 2018 19:17
@liggitt
Copy link
Member

liggitt commented Feb 14, 2018 •
edited
Loading

vendor/k8s.io/apiserver/pkg/endpoints/installer.go:243:30: isRedirector declared and not used

intent lgtm, likely requires test updates and generated API doc updates

@mikedanese mikedanese self-assigned this Feb 14, 2018
@mikedanese mikedanese force-pushed the remove-deprecated-proxy branch 2 times, most recently from b82d192 to 9df3f12 Compare February 14, 2018 21:44
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2018
@mikedanese
Copy link
Member Author

I should probably get rid of rest.Redirector while I'm in here. New proxy storages implement rest.Connector

@mikedanese mikedanese force-pushed the remove-deprecated-proxy branch from 9df3f12 to 56e6567 Compare February 15, 2018 01:01
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2018
@mikedanese mikedanese force-pushed the remove-deprecated-proxy branch from 56e6567 to 1ab6c82 Compare February 20, 2018 20:39
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 20, 2018
@mikedanese mikedanese force-pushed the remove-deprecated-proxy branch from 1ab6c82 to 531e6ab Compare February 20, 2018 20:40
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 20, 2018
@mikedanese mikedanese force-pushed the remove-deprecated-proxy branch from 531e6ab to f6e8a07 Compare February 20, 2018 20:48
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 20, 2018
@mikedanese mikedanese force-pushed the remove-deprecated-proxy branch from f6e8a07 to 3d76668 Compare February 20, 2018 20:51
@liggitt liggitt added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 20, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Feb 20, 2018
@mikedanese mikedanese force-pushed the remove-deprecated-proxy branch from 43ebdd7 to 6c5e800 Compare February 20, 2018 22:42
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 20, 2018 •
edited
Loading

@mikedanese: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-cross 1ab6c824fc3848731e43b895641ad02e1932aa14 link /test pull-kubernetes-cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikedanese
Copy link
Member Author

To review removal of conformance tests testing old proxy path:

/assign @smarterclayton

@mikedanese mikedanese added this to the v1.10 milestone Feb 21, 2018
@smarterclayton
Copy link
Contributor

/approve

Conformance removal is acceptable because these paths have been deprecated for 8 releases.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mikedanese, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2018
@mikedanese mikedanese added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 58716, 59977, 59316, 59884, 60117). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 687c651 into kubernetes:master Feb 21, 2018
@mikedanese mikedanese deleted the remove-deprecated-proxy branch February 22, 2018 00:02
@bgrant0607
Copy link
Member

LGTM, thanks

@liggitt liggitt mentioned this pull request Mar 5, 2018
Closed
@brancz brancz mentioned this pull request Mar 8, 2018
Closed
@xiangpengzhao xiangpengzhao mentioned this pull request Mar 13, 2018
Closed
@CaoShuFeng CaoShuFeng mentioned this pull request Mar 29, 2018
Closed
CaoShuFeng added a commit to CaoShuFeng/kubernetes.github.io that referenced this pull request Mar 29, 2018
@CaoShuFeng
fix description about root /proxy path
8e24cb3 
Fix issue: kubernetes/kubernetes#61826
Related change: kubernetes/kubernetes#59884
@CaoShuFeng CaoShuFeng mentioned this pull request Mar 29, 2018
Merged
@liggitt liggitt mentioned this pull request Apr 8, 2018
Closed
k8s-ci-robot pushed a commit to kubernetes/website that referenced this pull request Apr 9, 2018
@CaoShuFeng @k8s-ci-robot
fix description about root /proxy path (#7902)
0cc8592 
Fix issue: kubernetes/kubernetes#61826
Related change: kubernetes/kubernetes#59884
zacharysarah pushed a commit to kubernetes/website that referenced this pull request Apr 16, 2018
@CaoShuFeng
fix description about root /proxy path (#7902)
00858a8 
Fix issue: kubernetes/kubernetes#61826
Related change: kubernetes/kubernetes#59884
@andresmgot andresmgot mentioned this pull request Apr 25, 2018
Closed
@will-gtv will-gtv mentioned this pull request May 1, 2018
Closed
This was referenced May 10, 2018
Closed
Merged
@liggitt liggitt mentioned this pull request Jun 15, 2018
Merged
@Ark-kun Ark-kun mentioned this pull request Aug 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
6 participants
@mikedanese @liggitt @k8s-ci-robot @smarterclayton @k8s-github-robot @bgrant0607