Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing diskIsAttached function #59872

Merged
merged 2 commits into from
Feb 15, 2018
Merged

Fixing diskIsAttached function #59872

merged 2 commits into from
Feb 15, 2018

Conversation

divyenpatel
Copy link
Member

What this PR does / why we need it:
This PR fixes the diskIsAttached function.
When disk is detached from the Node, this function was returning true, which results into time out for some vsphere e2e test cases.

Which issue(s) this PR fixes
Fixes #

Special notes for your reviewer:
Executed E2E test to verify failures are resolved with this change.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 14, 2018
@divyenpatel
Copy link
Member Author

This regression is introduced from the recently merged PR: #59761

@divyenpatel
Copy link
Member Author

cc @jeffvance

@divyenpatel divyenpatel force-pushed the remove-production-code-usage-in-e2e-tests branch from 77d910a to d7c0228 Compare February 14, 2018 17:41
@jeffvance
Copy link
Contributor

/assign
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2018
@divyenpatel
Copy link
Member Author

/assign @jingxu97

@divyenpatel
Copy link
Member Author

@jingxu97 can you please approve this PR?

@jingxu97
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2018
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2018
@BaluDontu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2018
@jeffvance
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BaluDontu, divyenpatel, jeffvance, jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@divyenpatel
Copy link
Member Author

/test pull-kubernetes-verify

@divyenpatel
Copy link
Member Author

verify-openapi-spec is passing locally.

$ ./hack/verify-openapi-spec.sh
+++ [0214 16:48:36] Building the toolchain targets:
    k8s.io/kubernetes/hack/cmd/teststale
    k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
+++ [0214 16:48:36] Generating bindata:
    test/e2e/generated/gobindata_util.go
+++ [0214 16:48:36] Building go targets for darwin/amd64:
    cmd/kube-apiserver
+++ [0214 16:48:49] Building the toolchain targets:
    k8s.io/kubernetes/hack/cmd/teststale
    k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
+++ [0214 16:48:49] Generating bindata:
    test/e2e/generated/gobindata_util.go
+++ [0214 16:48:49] Building go targets for darwin/amd64:
    cmd/kube-apiserver
etcd --advertise-client-urls http://127.0.0.1:2379 --data-dir /var/folders/_c/jphrps7d6x5_v7s81fv3k0wr002gzv/T/tmp.cXwGLCOf --listen-client-urls http://127.0.0.1:2379 --debug > "/dev/null" 2>/dev/null
Waiting for etcd to come up.
+++ [0214 16:48:53] On try 2, etcd: : http://127.0.0.1:2379
{"action":"set","node":{"key":"/_test","value":"","modifiedIndex":4,"createdIndex":4}}
+++ [0214 16:48:53] Starting kube-apiserver
+++ [0214 16:48:57] On try 5, apiserver: : ok
+++ [0214 16:48:57] Updating 
    /Users/divyenp/github/vmware/kubernetes/hack/../api/openapi-spec
+++ [0214 16:48:57] SUCCESS
+++ [0214 16:48:57] Clean up complete
diffing /Users/divyenp/github/vmware/kubernetes/api/openapi-spec against freshly generated openapi spec
/Users/divyenp/github/vmware/kubernetes/api/openapi-spec up to date.

@divyenpatel
Copy link
Member Author

/test pull-kubernetes-verify

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 00070b5 into kubernetes:master Feb 15, 2018
@divyenpatel divyenpatel deleted the remove-production-code-usage-in-e2e-tests branch February 15, 2018 17:22
@divyenpatel divyenpatel mentioned this pull request Feb 15, 2018
Merged
@wojtek-t wojtek-t mentioned this pull request Apr 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@jeffvance jeffvance

@jingxu97 jingxu97

@BaluDontu BaluDontu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@divyenpatel @jeffvance @jingxu97 @BaluDontu @k8s-ci-robot @k8s-github-robot @fejta-bot