Avoid hook errors when effecting label changes on kubernetes-worker charm. #59803
Conversation
k8s-ci-robot
added
release-note
| # Set label for application name | ||
| _apply_node_label('juju-application={}'.format(hookenv.service_name()), | ||
| overwrite=True) | ||
| @when_any('kubernetes-worker.label-config-required') |
There was a problem hiding this comment.
There is something strange with this when_any
There was a problem hiding this comment.
Ah, thanks @ktsakalozos, nice catch.
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/test pull-kubernetes-bazel-test |
|
/assign @Cynerva |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cynerva, wwwtyro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these OWNERS Files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it: Avoid hook errors when effecting label changes on kubernetes-worker charm.
Release note: