Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requesting new credentials when node names change #59730

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Requesting new credentials when node names change #59730

merged 1 commit into from
Feb 12, 2018

Conversation

hyperbolic2346
Copy link
Contributor

What this PR does / why we need it:
Updating kubernetes-worker charm to request a new token when the node name changes due to a cloud provider change to kubelet-extra-args
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/491
Special notes for your reviewer:

Release note:

Updated kubernetes-worker to request new security tokens when the aws cloud provider changes the registered node name.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 11, 2018
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 11, 2018
@Cynerva
Copy link
Contributor

Cynerva commented Feb 12, 2018

/ok-to-test
/assign @Cynerva

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 12, 2018
@Cynerva
Copy link
Contributor

Cynerva commented Feb 12, 2018

/approve
/lgtm

👍 Thanks @hyperbolic2346

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, hyperbolic2346

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2018
@Cynerva
Copy link
Contributor

Cynerva commented Feb 12, 2018

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 59767, 56454, 59237, 59730, 55479). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f0acb4f into kubernetes:master Feb 12, 2018
@hyperbolic2346 hyperbolic2346 deleted the mwilson/auth-token-node-name branch April 4, 2018 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-mcmahon david-mcmahon Awaiting requested review from david-mcmahon

@eparis eparis Awaiting requested review from eparis

Assignees

@Cynerva Cynerva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hyperbolic2346 @Cynerva @k8s-ci-robot @k8s-github-robot @fejta-bot