Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused getClusterCIDR() #59683

Merged
merged 1 commit into from
Feb 16, 2018
Merged

Remove unused getClusterCIDR() #59683

merged 1 commit into from
Feb 16, 2018

Conversation

oomichi
Copy link
Member

@oomichi oomichi commented Feb 10, 2018

What this PR does / why we need it:

getClusterCIDR() has been unused since the PR 573051, so this
removes the method for code cleanup.

Release note: "NONE"

@k8s-ci-robot
Copy link
Contributor

@oomichi: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2018
@0xmichalis
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 10, 2018
fabriziopandini
fabriziopandini reviewed Feb 11, 2018
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oomichi thanks for this PR!

I'm fine with what you are proposing.

To complete the PR can you kindly cleanup the clusterCIDR variable at line 80 in cmd/kubeadm/app/phases/addons/proxy/proxy.go as well?

@oomichi
Copy link
Member Author

oomichi commented Feb 12, 2018

@fabriziopandini

Thank you for your review, that is a nice point :-)
OK, I will do that soon.

Remove unused getClusterCIDR()
30e4ba7 
getClusterCIDR() has been unused since the PR 57305[1], so this
removes the method for code cleanup.

[1]: kubernetes#57305
@dixudx
Copy link
Member

dixudx commented Feb 13, 2018

/area kubeadm
/release-note-none

/lgtm

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. area/kubeadm and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 13, 2018
fabriziopandini
fabriziopandini approved these changes Feb 13, 2018
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
👍

@oomichi
Copy link
Member Author

oomichi commented Feb 13, 2018

/assign @luxas

@fabriziopandini
Copy link
Member

/assign @timothysc for approval

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members and repo collaborators can be assigned.

In response to this:

/assign @timothysc for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timothysc
timothysc approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@timothysc
Copy link
Member

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Feb 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, fabriziopandini, oomichi, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2018
@oomichi
Copy link
Member Author

oomichi commented Feb 16, 2018

/test pull-kubernetes-bazel-build

@oomichi
Copy link
Member Author

oomichi commented Feb 16, 2018

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 6efdc94 into kubernetes:master Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini approved these changes

@timothysc timothysc timothysc approved these changes

@0xmichalis 0xmichalis Awaiting requested review from 0xmichalis

Assignees

@timothysc timothysc

@fabriziopandini fabriziopandini

@luxas luxas

@dixudx dixudx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@oomichi @k8s-ci-robot @0xmichalis @dixudx @fabriziopandini @timothysc @k8s-github-robot @luxas