Pass pvc namespace and annotations to Portworx Create API #59607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes kubernetes#59606 Signed-off-by: Harsh Desai <harsh@portworx.com>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
needs-ok-to-test
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harsh-px, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these OWNERS Files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 59607, 59232). If you want to cherry-pick this change to another branch, please follow the instructions here. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Feb 14, 2018
…07-upstream-release-1.8 Automatic merge from submit-queue. Automated cherry pick of #59607: Pass pvc namespace and annotations to Portworx Create API Cherry pick of #59607 on release-1.8. #59607: Pass pvc namespace and annotations to Portworx Create API **Release note**: ```release-note Fixed an issue where Portworx volume driver wasn't passing namespace and annotations to the Portworx Create API. ```
k8s-ci-robot
added
release-note
k8s-github-robot
pushed a commit
that referenced
this pull request
Feb 24, 2018
…07-upstream-release-1.9 Automatic merge from submit-queue. Automated cherry pick of #59607: Pass pvc namespace and annotations to Portworx Create API Cherry pick of #59607 on release-1.9. #59607: Pass pvc namespace and annotations to Portworx Create API **Release note**: ```release-note Fixed an issue where Portworx volume driver wasn't passing namespace and annotations to the Portworx Create API. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsh Desai harsh@portworx.com
What this PR does / why we need it:
Fixes #59606
Release note: