/assign @divyenpatel

/test pull-kubernetes-verify

/test pull-kubernetes-e2e-gce-device-plugin-gpu
/test pull-kubernetes-verify

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrarshivani, divyenpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

@stttts @jsafrane Can you please help removing label do-not-merge/cherry-pick-not-approved from this PR?

We nee to cherry pick this PR to 1.9 branch. This PR is fixing the bug reported by customer - #58927

/assign @mbohlool

@mbohlool is the 1.9 release manager. He has to approve this.

How this is tested? i.e. is it possible to add some [unit] test?

@mbohlool This is tested with running vsphere e2e test cases. E2E test cases are modified to use provider ID, as part of this PR - #59761

@mbohlool This is manually tested e2e on vSphere Infrastructure.

Tested:

Launched K8s cluster using kubeadm (Used Ubuntu VM compatible with vSphere version 6.5.)
Note: Installed Ubuntu from ISO
Observed following:

Master
> cat /sys/class/dmi/id/product_uuid
743F0E42-84EA-A2F9-7736-6106BB5DBF6B

> cat /sys/class/dmi/id/product_serial
VMware-42 0e 3f 74 ea 84 f9 a2-77 36 61 06 bb 5d bf 6b

Node
> cat /sys/class/dmi/id/product_uuid
956E0E42-CC9D-3D89-9757-F27CEB539B76

> cat /sys/class/dmi/id/product_serial
VMware-42 0e 6e 95 9d cc 89 3d-97 57 f2 7c eb 53 9b 76

With this fix controller manager was able to find the nodes.

can those tests be ported in 1.9 release branch too?

can those tests be ported in 1.9 release branch too?

@mbohlool in previous releases we were asked to not cherry pick test changes as guideline suggests "Patch releases should not contain new features, so ensure that cherry-picks are for bug/security fixes only." - https://github.com/kubernetes/sig-release/blob/master/ephemera/README.md#patch-release-manager

To cherry pick these tests to 1.9 branch we will have to cherry pick bunch of PRs

• Fixing usage of clustered datastore name to be absolute datastore name #54438
• Fixing node labels assignment for random order tests execution #59211
• Removing Production Code usage from vSphere E2E tests #59761
• Fixing diskIsAttached function #59872
• Created bootstrap logic for vSphere test #58713
• vSphere test infrastructure improvement and new node-unregister test #59514
• Add multi-vc configuration for e2e tests #57258
• e2e test layout changes for vsphere (#398) #56593

If test changes are allowed to be cherry picked then can we cherry pick them in separate PR?

@kubernetes/vmware

I guess I am a little nervous to have a code in 1.9 branch with no test. If you guys feel the feature does not need a test here, I can live with that. I definitely don't want a loads of e2e tests to be added for this change. If you want to add test, thought, it should be in the same PR.

(btw, how did you infer from the documentation that we do not cherry pick test changes? we do that all the time actually. Any code change comes into the branch should come with its test code).

@mbohlool No test is required to test this issue. Since earlier all e2e tests were failing when VM Hardware version was 13. After this fix, the tests are passing.

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

/test pull-kubernetes-e2e-kops-aws

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@mbohlool Test pull-kubernetes-e2e-kops-aws is failing continuously, seems to be an environmental issue. Would like to you know whether something needs to be done from our side?

/test pull-kubernetes-e2e-kops-aws

/test all [submit-queue is verifying that this PR is safe to merge]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

/test all [submit-queue is verifying that this PR is safe to merge]

Automatic merge from submit-queue.