Create pkg/kubelet/apis/deviceplugin/v1beta1 directory. #59588
Conversation
k8s-ci-robot
added
size/XXL
|
/assign @RenaudWasTaken @vishh @derekwaynecarr @ConnorDoyle I have added an agenda in next week's rmwg meeting to discuss creating deviceplugin/v1beta1 directory now, but as we have a couple of pending PRs that will make incompatible API changes, I would like to send out this PR now to get some early opinions. I think making incompatible api changes in the v1beta1 directory can avoid breaking existing device plugins and also makes it easy for a device plugin to support both v1alph api and v1beta1 api if it needs to. Please let me know if you have any objections. Thanks a lot! |
k8s-ci-robot
added
release-note
|
/assign @vikaschoudhary16 |
jiayingz
force-pushed
the
v1beta1
branch
3 times, most recently
from
16ef449 to
a17fd41
Compare
The proto stays the same as v1alpha. Only changes Version in constants.go to "v1beta1" and the BUILD file to pick up the new dir.
|
LGTM for the overall plan! I haven't looked closely at the individual fields yet. If there has been no changes since |
|
@vishh thanks a lot for reviewing this! The actual v1beta1 API stays the same as v1alpha2 in this PR. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiayingz, vikaschoudhary16, vishh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these OWNERS Files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/test pull-kubernetes-unit |
|
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
|
/retest Review the full test history for this PR. Silence the bot with an |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. KubeletPluginsWatcher feature is beta in 1.12 release *What this PR does / why we need it:* Graduates DevicePlugins feature to beta. *Which issue(s) this PR fixes:* Related but does not fix: kubernetes/enhancements#595 as well as #65773 *Special notes for your reviewer:* Includes upgrading the gRPC pluginwatcher API to beta. Based on the [device plugin model](#59588). *Depends on #64621 being merged* Release note: ```release-note KubeletPluginsWatcher feature graduates to beta. ``` /sig node /sig storage /cc @vladimirvivien @sbezverk @vikaschoudhary16 @saad-ali @vishh @jiayingz
The proto stays the same as v1alpha. Only changes Version in
constants.go to "v1beta1" and the BUILD file to pick up the new dir.