Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set instanceID to azure resource ID format while useInstanceMetadata is enabled #59539

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Set instanceID to azure resource ID format while useInstanceMetadata is enabled #59539

merged 1 commit into from
Feb 8, 2018

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Feb 8, 2018

What this PR does / why we need it:

This PR sets instanceID to azure resource ID format while useInstanceMetadata is enabled.

Before this PR, it is azure://d84a1c30-0c9f-11e8-8a34-000d3a919531.

With this PR, it becomes azure:///subscriptions/<id>/resourceGroups/<rg>/providers/Microsoft.Compute/virtualMachines/<node-name>

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

This PR is only for vmas and could be cherry-picked to old releases. There will be another PR for vmss after this.

Should cherry-pick to release 1.8 and 1.9.

Release note:

Node's providerID is following Azure resource ID format now when useInstanceMetadata is enabled

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 8, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2018
@feiskyer
Copy link
Member Author

feiskyer commented Feb 8, 2018

/sig azure

@feiskyer feiskyer requested a review from andyzhangx February 8, 2018 07:18
andyzhangx
andyzhangx approved these changes Feb 8, 2018
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer
Copy link
Member Author

feiskyer commented Feb 8, 2018

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@feiskyer
Copy link
Member Author

feiskyer commented Feb 8, 2018

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 8, 2018 •
edited
Loading

@feiskyer: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit 20de29a link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 59539, 59309). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit b133434 into kubernetes:master Feb 8, 2018
@feiskyer feiskyer mentioned this pull request Feb 9, 2018
Merged
@feiskyer feiskyer deleted the meta branch February 9, 2018 01:11
This was referenced Feb 9, 2018
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Feb 10, 2018
Merge pull request #59604 from feiskyer/automated-cherry-pick-of-#595…
849d464 
…39-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #59539: Set instanceID to azure resource ID format while

Cherry pick of #59539 on release-1.8.

#59539: Set instanceID to azure resource ID format while
k8s-github-robot pushed a commit that referenced this pull request Feb 16, 2018
Merge pull request #59603 from feiskyer/automated-cherry-pick-of-#595…
032ec12 
…39-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #59539: Set instanceID to azure resource ID format while

Cherry pick of #59539 on release-1.9.

#59539: Set instanceID to azure resource ID format while
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@jdumars jdumars Awaiting requested review from jdumars

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@feiskyer @k8s-ci-robot @k8s-github-robot @andyzhangx