/assign @divyenpatel
/assign @abrarshivani
/assign @BaluDontu

/approve

/ok-to-test

cc @deads2k
for cloud provider informer registration… not sure this is in the normal init flow

@liggitt this is exactly the GCE does too - http://dims.dynu.net/hound/?q=SetInformers&i=nope&files=&repos=kubernetes - so LGTM 👍

@liggitt this is exactly the GCE does too

Understood. It's possible that is problematic as well. Wanted @deads2k eyes on the init flow

Ack :) @liggitt

for cloud provider informer registration… not sure this is in the normal init flow

The cloud provider init code is pretty icky to begin with. I'd like to see a separate method for building the cloud provider that has args for every input it wants so we can start trying to see where the weird links are. I think a CloudControllerContext that includes the ControllerContext will give us a way to reliably wrap the controller context and then we can see which controllers are reliant on the cloud provider and need work to remove that dependency or remove the controller.

That would allow this flow to be splittable without weird side-effects as we split the cloud related controllers.

@deads2k, @liggitt, @dims,

Is there anything more that vSphere Cloud Provider can do here?

/hold

wait for #59568 to merge

oops. forgot to remove hold.

/hold cancel
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, divyenpatel, rohitjogvmw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

/test all [submit-queue is verifying that this PR is safe to merge]

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.