Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure public IP removed after service deleted #59340

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Ensure public IP removed after service deleted #59340

merged 1 commit into from
Feb 6, 2018

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Feb 5, 2018

What this PR does / why we need it:

When creating many LoadBalancer services, some services may exceed Azure basic LB's FrontendIPConfiguations quota (default is 10). Public IPs are created for all services, but it is not removed after deleting the kubernetes services.

This PR fixes the problem.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #59255

Special notes for your reviewer:

Should cherry-pick to v1.9.

Release note:

Ensure Azure public IP removed after service deleted

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 5, 2018
@feiskyer
Copy link
Member Author

feiskyer commented Feb 5, 2018

/sig azure

@feiskyer
Copy link
Member Author

feiskyer commented Feb 5, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 5, 2018
@feiskyer feiskyer requested a review from karataliu February 6, 2018 06:48
@feiskyer
Copy link
Member Author

feiskyer commented Feb 6, 2018

@karataliu @andyzhangx Could you take a look at this?

andyzhangx
andyzhangx suggested changes Feb 6, 2018
View reviewed changes
pkg/cloudprovider/providers/azure/azure_loadbalancer.go Outdated
@@ -383,10 +383,12 @@ func (az *Cloud) findServiceIPAddress(clusterName string, service *v1.Service, i
return "", err
}
if !existsLb {
return "", fmt.Errorf("Expected to find an IP address for service %s but did not", service.Name)
glog.V(4).Infof("Expected to find an IP address for service %s but did not. Assuming it has been removed", service.Name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set as glog.V(2) ? as default is 2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or Warningf ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be treated as normal message, changed to V(2)

pkg/cloudprovider/providers/azure/azure_loadbalancer.go Outdated
}
if len(lbStatus.Ingress) < 1 {
return "", fmt.Errorf("Expected to find an IP address for service %s but it had no ingresses", service.Name)
glog.V(4).Infof("Expected to find an IP address for service %s but it had no ingresses. Assuming it has been removed", service.Name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set as glog.V(2) ? as default is 2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or Warningf ?

@andyzhangx
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@feiskyer
Copy link
Member Author

feiskyer commented Feb 6, 2018

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 87f77cd into kubernetes:master Feb 6, 2018
@feiskyer feiskyer deleted the fip branch February 7, 2018 02:05
@feiskyer feiskyer mentioned this pull request Feb 7, 2018
Merged
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

k8s-github-robot pushed a commit that referenced this pull request Feb 16, 2018
Merge pull request #59453 from feiskyer/automated-cherry-pick-of-#593…
6c98a8e 
…40-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #59340: Ensure public IP removed after service deleted

Cherry pick of #59340 on release-1.9.

#59340: Ensure public IP removed after service deleted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@jdumars jdumars Awaiting requested review from jdumars

@karataliu karataliu Awaiting requested review from karataliu

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PublicIP not removed after deleting LoadBalancer service
6 participants
@feiskyer @andyzhangx @k8s-ci-robot @k8s-github-robot @fejta-bot @k8s-cherrypick-bot