Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #59083: Ensure IP is set for Azure internal loadbalancer #59277

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Automated cherry pick of #59083: Ensure IP is set for Azure internal loadbalancer #59277

merged 2 commits into from
Feb 6, 2018

Conversation

brendandburns
Copy link
Contributor

Cherry pick of #59083 on release-1.9.

#59083: Ensure IP is set for Azure internal loadbalancer

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 2, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 2, 2018
@brendandburns brendandburns mentioned this pull request Feb 2, 2018
Merged
@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Feb 3, 2018
feiskyer
feiskyer reviewed Feb 5, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gofmt varification still failed. run hack/update-gofmt.sh

@brendandburns brendandburns force-pushed the automated-cherry-pick-of-#59083-upstream-release-1.9 branch from 4745274 to 5647f0e Compare February 5, 2018 15:07
@brendandburns
Copy link
Contributor Author

@jdumars @feiskyer this is ready to go now, I think...

@jdumars
Copy link
Member

jdumars commented Feb 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, jdumars

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@feiskyer
Copy link
Member

feiskyer commented Feb 6, 2018

LGTM

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit ac1d59b into kubernetes:release-1.9 Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@jdumars jdumars

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brendandburns @jdumars @k8s-ci-robot @feiskyer @k8s-github-robot @mbohlool