Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI 0.2.0 breaking changes #59209

Merged
merged 2 commits into from
Feb 17, 2018
Merged

CSI 0.2.0 breaking changes #59209

merged 2 commits into from
Feb 17, 2018

Conversation

sbezverk
Copy link
Contributor

@sbezverk sbezverk commented Feb 1, 2018 •
edited
Loading

Refactor kubernetes CSI bits to support CSI version 0.2.0

Addressing breaking changes introduced by new 0.2.0 release of CSI spec

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 1, 2018
@sbezverk
Copy link
Contributor Author

sbezverk commented Feb 1, 2018

/sig storage
/kind bug
/assign @saad-ali @vladimirvivien

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/bug Categorizes issue or PR as related to a bug. labels Feb 1, 2018
@sbezverk sbezverk changed the title Csi 0.2.0 breaking changes CSI 0.2.0 breaking changes Feb 1, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 15, 2018
@sbezverk
Copy link
Contributor Author

@saad-ali @vladimirvivien @lpabon I have tested successfully this k8s csi core change with all external components:
external-provisioner, external-attacher, driver-registrar and rbdplugin all on v0.2.0 spec.
I think it is ready, appreciate your input.

@saad-ali
Copy link
Member

We can pick up the official 0.2 once that is cut (hoping that will happen EOW next week).

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2018
@saad-ali
Copy link
Member

For vendor dir approval

/assign @brendanburns

@k8s-ci-robot
Copy link
Contributor

@saad-ali: GitHub didn't allow me to assign the following users: brendanburns.

Note that only kubernetes members and repo collaborators can be assigned.

In response to this:

For vendor dir approval

/assign @brendanburns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbezverk
Copy link
Contributor Author

/assign @brendandburns

@brendandburns
Copy link
Contributor

We generally split the vendor updates out as a separate commit.

@k8s-ci-robot k8s-ci-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 16, 2018
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 16, 2018
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2018
@sbezverk
Copy link
Contributor Author

@brendandburns done

@saad-ali
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2018
@sbezverk
Copy link
Contributor Author

/assign @brendandburns

@brendandburns
Copy link
Contributor

/approve no-issue

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, saad-ali, sbezverk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 220bdf2 into kubernetes:master Feb 17, 2018
@jberkus jberkus mentioned this pull request Mar 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootfs rootfs Awaiting requested review from rootfs

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@vladimirvivien vladimirvivien

@brendandburns brendandburns

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sbezverk @saad-ali @k8s-ci-robot @brendandburns @k8s-github-robot @vladimirvivien