Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue with capitalization in allow-privileged #59116

Merged
merged 2 commits into from
Feb 1, 2018
Merged

Fixing issue with capitalization in allow-privileged #59116

merged 2 commits into from
Feb 1, 2018

Conversation

hyperbolic2346
Copy link
Contributor

What this PR does / why we need it:
Config option in kubernetes-master allow-privileged would do odd things if you used True instead of true.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/374
Special notes for your reviewer:

Release note:

Fixed issue with kubernetes-worker option allow-privileged not properly handling the value True with a capital T.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2018
@Cynerva
Copy link
Contributor

Cynerva commented Jan 31, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 31, 2018
@Cynerva
Copy link
Contributor

Cynerva commented Jan 31, 2018

@hyperbolic2346 If we're fixing this in kubernetes-worker, can we fix it in kubernetes-master too? It also has the allow-privileged option and I would like to keep their behavior consistent.

See https://github.com/hyperbolic2346/kubernetes-1/blob/ec0bedbf43360e29be32fc0e538a20678f6c3fe0/cluster/juju/layers/kubernetes-master/reactive/kubernetes_master.py#L841

@hyperbolic2346
Copy link
Contributor Author

@Cynerva Added in kubernetes-master changes.

@Cynerva
Copy link
Contributor

Cynerva commented Jan 31, 2018

Thanks!

/approve no-issue
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, hyperbolic2346

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 57683, 59116, 58728, 59140, 58976). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 57bd4f8 into kubernetes:master Feb 1, 2018
@Cynerva Cynerva mentioned this pull request Apr 2, 2018
Merged
@hyperbolic2346 hyperbolic2346 deleted the mwilson/priv-typo-fix branch April 4, 2018 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cynerva Cynerva Awaiting requested review from Cynerva

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@Cynerva Cynerva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyperbolic2346 @Cynerva @k8s-ci-robot @k8s-github-robot