Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let client ca post start hook use GET to check if the system namespace exists #59073

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Let client ca post start hook use GET to check if the system namespace exists #59073

merged 1 commit into from
Jan 31, 2018

Conversation

caesarxuchao
Copy link
Member

@caesarxuchao caesarxuchao commented Jan 30, 2018 •
edited
Loading

This is a direct fix for #56761.

The original code tried to create a namespace unconditionally, it caused apiserver to fail to reboot if a webhook blocked namespaces creation.

In the long term, we should make the apiserver return 409 instead of 5xx in the case of conflicting POST, even if a webhook fails the POST.

Fixed a bug which caused the apiserver reboot failure in the presence of malfunctioning webhooks.

@caesarxuchao caesarxuchao added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 30, 2018
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 30, 2018
lavalamp
lavalamp reviewed Jan 30, 2018
View reviewed changes
pkg/master/client_util.go
coreclient "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/core/internalversion"
)

func createNamespaceIfNeeded(c coreclient.NamespacesGetter, ns string) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to combine with the version in controller.go?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are calling this private function now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really need its own file? This is so trivial. More boilerplate than code. And being in utils.go does not make it clearer. Calling private funcs in a package is fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't absolutely need its own file but it keeps clutter out of other files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a matter of taste. Am fine with this file, I just wouldn't have created it ;-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still prefer this over making ca post hook call a private function defined in controller.go :)

Client ca post start hook now checks if the system namespace already …
83d535a 
…exists

before creating it.

This avoids apiserver crashloops if a webhook rejects namespace
creation when the apiserver is rebooted.
@lavalamp
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, lavalamp

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2018
@sttts sttts added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 31, 2018
@sttts
Copy link
Contributor

sttts commented Jan 31, 2018

Please cherry-pick into 1.9.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 65c0d55 into kubernetes:master Jan 31, 2018
@k8s-ci-robot
Copy link
Contributor

@caesarxuchao: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu 83d535a link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@caesarxuchao caesarxuchao mentioned this pull request Jan 31, 2018
Merged
@caesarxuchao caesarxuchao added this to the v1.9 milestone Jan 31, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 2, 2018
k8s-github-robot pushed a commit that referenced this pull request Feb 3, 2018
Merge pull request #59134 from caesarxuchao/automated-cherry-pick-of-…
eefb791 
…#59073-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #59073: Client ca post start hook now checks if the system namespace

Cherry pick of #59073 on release-1.9.

#59073: Client ca post start hook now checks if the system namespace
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.9" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@jennybuckley jennybuckley mentioned this pull request Mar 5, 2018
Closed
@jennybuckley jennybuckley mentioned this pull request Mar 20, 2018
Closed
@liggitt liggitt mentioned this pull request Oct 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@lavalamp lavalamp lavalamp left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@janetkuo janetkuo Awaiting requested review from janetkuo

Assignees

@lavalamp lavalamp

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
6 participants
@caesarxuchao @lavalamp @k8s-ci-robot @sttts @k8s-github-robot @k8s-cherrypick-bot