Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix GetCustomResourceListerCollectionDeleter comments #58914

Merged
merged 1 commit into from
Jan 30, 2018
Merged

fix GetCustomResourceListerCollectionDeleter comments #58914

merged 1 commit into from
Jan 30, 2018

Conversation

hzxuzhonghu
Copy link
Member

What this PR does / why we need it:

fix #58688 (comment)

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 27, 2018
@k8s-ci-robot k8s-ci-robot requested review from enisoc and sttts January 27, 2018 08:03
@hzxuzhonghu
Copy link
Member Author

/assign @sttts @mbohlool

@hzxuzhonghu
Copy link
Member Author

@sttts for approval

@nikhita
Copy link
Member

nikhita commented Jan 27, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2018
@sttts
Copy link
Contributor

sttts commented Jan 30, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, nikhita, sttts

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@nikhita
Copy link
Member

nikhita commented Jan 30, 2018

/retest

@k8s-ci-robot
Copy link
Contributor

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit 6abde54 link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 58914, 58933). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 7cd474f into kubernetes:master Jan 30, 2018
@nikhita nikhita mentioned this pull request Feb 5, 2018
Closed
@hzxuzhonghu hzxuzhonghu mentioned this pull request Feb 6, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Feb 6, 2018
Merge pull request #59385 from hzxuzhonghu/automated-cherry-pick-of-#…
d283541 
…58438-#58914-origin-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #58438: fix apiserver crash caused by nil pointer and ensure CRD #58914: fix GetCustomResourceListerCollectionDeleter comments

Cherry pick of #58438 #58914 on release-1.9.

#58438: fix apiserver crash caused by nil pointer and ensure CRD
#58914: fix GetCustomResourceListerCollectionDeleter comments

```release-note
CustomResourceDefinitions: OpenAPI v3 validation schemas containing `$ref`references are no longer permitted. Before upgrading, ensure CRD definitions do not include those `$ref` fields.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enisoc enisoc Awaiting requested review from enisoc

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

@mbohlool mbohlool

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hzxuzhonghu @nikhita @sttts @k8s-ci-robot @k8s-github-robot @mbohlool