use containing API group when resolving shortname from discovery #58741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
size/XS
|
/kind bug |
k8s-ci-robot
added
kind/bug
dixudx
force-pushed
the
fix_kubectl_alias_group
branch
from
1b22e3b to
d5facf7
Compare
k8s-ci-robot
added
size/M
liggitt
reviewed
Jan 24, 2018
| @@ -115,6 +115,9 @@ func (e shortcutExpander) expandResourceShortcut(resource schema.GroupVersionRes | |||
| } | |||
There was a problem hiding this comment.
probably add the same check if version is present and not equal
There was a problem hiding this comment.
ah, nevermind... version isn't in the shortcut mapping
|
@dixudx A test in |
liggitt
reviewed
Jan 24, 2018
| @@ -115,6 +115,9 @@ func (e shortcutExpander) expandResourceShortcut(resource schema.GroupVersionRes | |||
| } | |||
| if resource.Resource == item.ShortForm.Resource { | |||
| resource.Resource = item.LongForm.Resource | |||
| if len(resource.Group) == 0 { | |||
There was a problem hiding this comment.
I think this should unconditionally set to item.LongForm.Group
dixudx
force-pushed
the
fix_kubectl_alias_group
branch
from
d5facf7 to
97ec47b
Compare
k8s-ci-robot
added
size/S
|
@nikhita Tests have already been added. PTAL. Thanks. /cc @kubernetes/sig-cli-pr-reviews |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dixudx, liggitt Associated issue: #58695 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 58302, 58782, 58555, 58741). If you want to cherry-pick this change to another branch, please follow the instructions here. |
yasker
added a commit
to yasker/longhorn-manager
that referenced
this pull request
Jun 27, 2018
There is a bug before Kubernetes v1.10 that kubectl will incorrectly parse the shorthand resource name without checking the full name. It can result in `kubectl delete lhn --all` will be treated as `kubectl delete node --all`. The bug is kubernetes/kubernetes#58741 The bug has been fixed since v1.10 release.
yasker
added a commit
to longhorn/longhorn-manager
that referenced
this pull request
Jun 27, 2018
There is a bug before Kubernetes v1.10 that kubectl will incorrectly parse the shorthand resource name without checking the full name. It can result in `kubectl delete lhn --all` will be treated as `kubectl delete node --all`. The bug is kubernetes/kubernetes#58741 The bug has been fixed since v1.10 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
kubectl does not use containing API group when resolving shortname from discovery
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #58695
Special notes for your reviewer:
/assign @liggitt
/cc @nikhita @zjj2wry
Release note: