Fix data race in kubelet fake_docker_client #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // This is not a very good fake. We'll just add this container's name to the list. | ||
| // Docker likes to add a '/', so copy that behavior. | ||
| name := "/" + c.Name | ||
| f.lock.Lock() |
There was a problem hiding this comment.
Move to top of function
|
minor comments, LGTM otherwise. |
|
Rebased. Could you please review once again? |
|
LGTM once you add back the clearCalls() method to fix travis :) |
- Fix reslice in Pull() to remove the just returned error - Fix data races found during the integration testing - Remove one-liner helper method for better readability
|
:) fixed |
|
LGTM |
lavalamp
added a commit
that referenced
this pull request
Jul 23, 2014
Fix data race in kubelet fake_docker_client
|
Thanks for the change! |
vishh
added a commit
to vishh/kubernetes
that referenced
this pull request
Apr 6, 2016
Add alias and namespace information to /spec endpoint
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Feb 24, 2021
UPSTREAM: 99199: delay serving CRD creates for a few seconds for HA consistency
linxiulei
pushed a commit
to linxiulei/kubernetes
that referenced
this pull request
Jan 18, 2024
Add a check if the metric is nil so that collector doesn't collect metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.